Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include src of moved files in list of modified files #415

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jan 7, 2019

If a file is moved during a pull request, we want to run plan in both the new and old directories (since they've both changed).

Notes:

kent-b and others added 2 commits January 7, 2019 14:12
Implement the change from the previous commit for GitLab and Bitbucket
Server/Cloud. Test the change for GitHub.

If a file is moved, we want to run plan in the directory it is moved to
*and* the directory it was moved from.
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #415 into master will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   70.27%   70.22%   -0.06%     
==========================================
  Files          63       63              
  Lines        3896     3902       +6     
==========================================
+ Hits         2738     2740       +2     
- Misses        964      967       +3     
- Partials      194      195       +1
Impacted Files Coverage Δ
server/events/vcs/bitbucketserver/client.go 31.57% <0%> (-0.43%) ⬇️
server/events/vcs/gitlab_client.go 19.44% <0%> (-0.37%) ⬇️
server/events/vcs/github_client.go 68.75% <100%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d07268...3d8138d. Read the comment docs.

@lkysow lkysow merged commit 89516f0 into master Jan 7, 2019
@lkysow lkysow deleted the moved-files branch January 7, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants