-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix broken formatting of first comment in case of command output truncation #4980
Conversation
Hi @benoittoulme, can you add before and after screenshots for this to the description as evidence that it is fixed, and I will then get it merged for you. The PR description should also have a |
I updated the description of the PR with 2 screenshots. |
Thanks @benoittoulme, merging now. |
… truncation (runatlantis#4980) Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com> Signed-off-by: a1k0u <alko7enko@gmail.com>
what
Before this fix:
After this fix:
why
chore: use markdown to display github comments truncation header #4885
<details>
wrapping, that allows to display the rest of the message properly. My previous PR attempted to fix the formatting and worked in my tests, unfortunately, it missed re-introducing the wrapping.tests
deployed atlantis 0.30.0 and tested the comment markdown on a github comment.
references
--max-comments-per-command
configuration #3905