Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken formatting of first comment in case of command output truncation #4980

Merged
merged 8 commits into from
Oct 24, 2024
Merged

fix: fix broken formatting of first comment in case of command output truncation #4980

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9ae6d30
fix broken formatting
benoittoulme Oct 4, 2024
14d746d
add details into the truncation header
benoittoulme Oct 4, 2024
408e0b2
Merge branch 'main' into truncate-header
benoittoulme Oct 8, 2024
b2d6a9a
Merge branch 'main' into truncate-header
jamengual Oct 10, 2024
5f4f082
Merge branch 'main' into truncate-header
benoittoulme Oct 15, 2024
93619d7
Merge branch 'main' into truncate-header
benoittoulme Oct 18, 2024
b9e5dc7
Merge branch 'main' into truncate-header
benoittoulme Oct 21, 2024
7c5eb3c
Merge branch 'main' into truncate-header
benoittoulme Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion server/events/vcs/github_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,8 @@ func (g *GithubClient) CreateComment(logger logging.SimpleLogging, repo models.R
}

truncationHeader := "> [!WARNING]\n" +
"> **Warning**: Command output is larger than the maximum number of comments per command. Output truncated.\n"
"> **Warning**: Command output is larger than the maximum number of comments per command. Output truncated.\n<details><summary>Show Output</summary>\n\n" +
"```diff\n"

comments := common.SplitComment(comment, maxCommentLength, sepEnd, sepStart, g.maxCommentsPerCommand, truncationHeader)
for i := range comments {
Expand Down