Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reqwest instead of ureq for download #98

Closed
wants to merge 1 commit into from

Conversation

nickfarrow
Copy link

Attempt at resolving MSRV issues caused by ureq: #95

I believe this reqwest version 0.10 has MSRV 1.39.0

Use reqwest version 0.10 (MSRV of 1.39.0) to resolve MSRV issue rust-bitcoin#95
@RCasatta
Copy link
Collaborator

RCasatta commented Nov 8, 2022

Thanks for the PR.
I opened another one #99 based on yours because I want to target the 0.27.* branch to support MSRV 1.41.1

Unfortunately it doesn't look that reqwest 0.10.x has MSRV 1.39:

$ cargo +1.41.1 check
error: failed to download `indexmap v1.9.1`

Caused by:
  unable to get packages from source

Caused by:
  failed to parse manifest at `/home/casatta/.cargo/registry/src/gh.neting.cc-1ecc6299db9ec823/indexmap-1.9.1/Cargo.toml`

Caused by:
  failed to parse the `edition` key

Caused by:
  supported edition values are `2015` or `2018`, but `2021` is unknown
$ cargo tree -i indexmap
indexmap v1.9.1
└── h2 v0.2.7
    └── hyper v0.13.10
        ├── hyper-tls v0.4.3
        │   └── reqwest v0.10.10
        │       [build-dependencies]
        │       └── bitcoind v0.27.1 (/home/casatta/git/bitcoind)
        └── reqwest v0.10.10 (*)

@nickfarrow
Copy link
Author

Ahh damn... Do you know why the reqwest CI says 1.39? I guess i'm going to have to look for another crate... running out of options

@RCasatta
Copy link
Collaborator

I didn't investigate the reasons, but I supposed semver of dependencies now select newer deps than the one selected when that CI was run

@RCasatta
Copy link
Collaborator

I think #102 is approximately solving the MSRV issues

@RCasatta RCasatta closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants