Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Debug, PartialEq and Eq for more types #141

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Derive Debug, PartialEq and Eq for more types #141

merged 1 commit into from
Apr 24, 2019

Conversation

jonas-schievink
Copy link
Contributor

Closes #28

@jonas-schievink jonas-schievink requested a review from a team as a code owner April 24, 2019 13:17
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Apr 24, 2019
therealprof
therealprof approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Apr 24, 2019
@bors @jonas-schievink
Merge #141
10d6e25 
141: Derive Debug, PartialEq and Eq for more types r=therealprof a=jonas-schievink

Closes #28

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 24, 2019

Build succeeded

@bors bors bot merged commit fdf0c88 into rust-embedded:master Apr 24, 2019
@jonas-schievink jonas-schievink deleted the debug branch April 24, 2019 15:56
adamgreig pushed a commit that referenced this pull request Jan 12, 2022
@bors @japaric
Merge #141
3d43614 
141: entry/exception/interrupt: reachability restriction is 1.30-only r=therealprof a=japaric

Thanks to rust-lang/rust#54451, which will be available in 1.31, these
attributes will work regardless of the visibility and reachability of the items.

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[derive(Debug)] for every struct/enum without volatile fields
4 participants
@jonas-schievink @rust-highfive @therealprof @adamgreig