Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triagebot configuration #202

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Conversation

LeSeulArtichaut
Copy link
Contributor

This enables assignment through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@therealprof
Copy link
Contributor

Is there a newer nightly that includes the rustfmt component?

@ryankurte
Copy link
Contributor

I don't think we actually specify a nightly version? (in which case, this seems to me it should be an allowed failure?)

@bors
Copy link
Contributor

bors bot commented Apr 13, 2020

Build succeeded:

@bors bors bot merged commit 181d44b into rust-embedded:master Apr 13, 2020
@therealprof
Copy link
Contributor

Yeah it should. However it seems there's fixed nightly build so now we can also r+ all the other repos. ;)

@LeSeulArtichaut LeSeulArtichaut deleted the patch-1 branch April 14, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants