Handle r? as assignment #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds parsing support for handling r? to direct assignment; anyone can do so on a PR to any org member. A future commit will add support for r? with a team. This does not currently auto-assign reviewers like highfive to new PRs, though.
| }, | ||
| )); | ||
| } else { | ||
| log::trace!("{:?} had non-one mention: {:?}", w, mentions); |
There was a problem hiding this comment.
I think it might be useful to allow more than a person to be assigned: occasionally I write r? @foo @bar and manually assign @bar once highfive assigns @foo. Highfive was written before GitHub allowed multiple assignees, so I guess that's the reason why highfive didn't support that.
There was a problem hiding this comment.
I largely agree, though I think it is pretty useful to have just one person assigned at a time -- then there's less "well they'll do it" :)
But I don't want to try to make things better before we make things work; migrating things to triagebot is the first priority, and then once that's done we can enhance.
|
Other than that comment this PR looks good! |
This was referenced Mar 31, 2020
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Mar 31, 2020
Add triagebot configuration This enables assignment through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433
This was referenced Mar 31, 2020
This was referenced Apr 13, 2020
bors bot
added a commit
to rust-embedded/embedded-alloc
that referenced
this pull request
Apr 13, 2020
30: Add triagebot configuration r=jonas-schievink a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/bare-metal
that referenced
this pull request
Apr 13, 2020
30: Add triagebot configuration r=jonas-schievink a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
This was referenced Apr 13, 2020
bors bot
added a commit
to rust-embedded/not-yet-awesome-embedded-rust
that referenced
this pull request
Apr 13, 2020
18: Add triagebot configuration r=adamgreig a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/awesome-embedded-rust
that referenced
this pull request
Apr 13, 2020
263: Add triagebot configuration r=adamgreig a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/cortex-m-rt
that referenced
this pull request
Apr 13, 2020
263: Add triagebot configuration r=jonas-schievink a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/svd2rust
that referenced
this pull request
Apr 13, 2020
435: Add triagebot configuration r=therealprof a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/svd
that referenced
this pull request
Apr 13, 2020
110: Add triagebot configuration r=therealprof a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/linux-embedded-hal
that referenced
this pull request
Apr 13, 2020
40: Add triagebot configuration r=posborne a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/rust-sysfs-gpio
that referenced
this pull request
Apr 13, 2020
63: Add triagebot configuration r=ryankurte a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/rust-i2cdev
that referenced
this pull request
Apr 13, 2020
61: Add triagebot configuration r=ryankurte a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/embedded-hal
that referenced
this pull request
Apr 13, 2020
202: Add triagebot configuration r=ryankurte a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/rust-spidev
that referenced
this pull request
Apr 13, 2020
23: Add triagebot configuration r=ryankurte a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/rust-sysfs-pwm
that referenced
this pull request
Apr 13, 2020
11: Add triagebot configuration r=ryankurte a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/svd2rust
that referenced
this pull request
Apr 13, 2020
435: Add triagebot configuration r=therealprof a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/showcase
that referenced
this pull request
Apr 13, 2020
22: Add triagebot configuration r=therealprof a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/blog
that referenced
this pull request
Apr 13, 2020
119: Add triagebot configuration r=therealprof a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/itm
that referenced
this pull request
Apr 13, 2020
28: Add triagebot configuration r=therealprof a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to cross-rs/cross
that referenced
this pull request
Apr 13, 2020
408: Add triagebot configuration r=Dylan-DPC a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/gpio-utils
that referenced
this pull request
Apr 14, 2020
30: Add triagebot configuration r=ryankurte a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/embedonomicon
that referenced
this pull request
Apr 14, 2020
65: Add triagebot configuration r=ryankurte a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/rust-embedded.github.io
that referenced
this pull request
Apr 14, 2020
22: Add triagebot configuration r=ryankurte a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/discovery
that referenced
this pull request
Apr 14, 2020
223: Add triagebot configuration r=ryankurte a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/svd2rust
that referenced
this pull request
Apr 22, 2020
435: Add triagebot configuration r=therealprof a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot
added a commit
to rust-embedded/rust-embedded.github.io
that referenced
this pull request
Jul 4, 2020
22: Add triagebot configuration r=ryankurte a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
|
|
bors bot
added a commit
to rust-embedded/itm
that referenced
this pull request
Jul 25, 2020
28: Add triagebot configuration r=jonas-schievink a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
Closed
adamgreig
pushed a commit
to rust-embedded/cortex-m
that referenced
this pull request
Jan 12, 2022
263: Add triagebot configuration r=jonas-schievink a=LeSeulArtichaut This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment. cc rust-lang/highfive#258 rust-lang/triagebot#433 Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
|
This can be closed since the functionality is now implemented, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds parsing support for handling r? to direct assignment; anyone can do so
on a PR to any org member.
A future commit will add support for r? with a team.
This does not currently auto-assign reviewers like highfive to new PRs, though.