Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try updating base image to bionic to fix build woes #290

Closed
wants to merge 1 commit into from

Conversation

therealprof
Copy link
Contributor

No description provided.

@therealprof therealprof requested a review from a team as a code owner May 7, 2019 18:42
@rust-highfive
Copy link

r? @Emilgardis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels May 7, 2019
@therealprof
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 7, 2019
@bors
Copy link
Contributor

bors bot commented May 7, 2019

try

Build failed

@Emilgardis
Copy link
Member

The error (AFAICS) is from cross, furthermore, the image cross uses.

This is rather frustrating but it is how things are right now. We'll need to provide (or find) images for cross that has our needs. See cross-rs/cross#164 (comment) for why we're not updating glibc in "official" cross images.

As for where this error comes from, I'm not sure. Could be git

I think this is something we need to prioritize for svd2rust, as it's currently the biggest blocker for PRs. May be something for 2019 tools team objectives.

@therealprof
Copy link
Contributor Author

TBH I've no idea why we need this amount of magic and fluff anyway instead of simply using the standard rust toolchain to test compile the generated PACs.

@Disasm
Copy link
Member

Disasm commented May 18, 2019

I see two solutions:

  • Fixing all the targets in cross and rolling out cross-2.0 release. I created a PR for relevant targets.
  • Temporarily disabling cross-builds (replacing with cargo-builds) in svd2rust and optionally goto step1. This involves disabling some non-Linux CI targets.

@therealprof
Copy link
Contributor Author

While cross-compilation is nice and very useful, I don't really get why we to support cross-compilation for ancient or nostalgic targets. If someone wants to build for CentOS 7 why not use a CentOS 7 docker container and compile natively?

@Disasm
Copy link
Member

Disasm commented May 18, 2019

@therealprof
Copy link
Contributor Author

Withdrawing due to #297 fixing the issue.

@therealprof therealprof deleted the use-bionic-as-base branch May 22, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants