-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try updating base image to bionic to fix build woes #290
Conversation
r? @Emilgardis (rust_highfive has picked a reviewer for you, use r? to override) |
bors try |
tryBuild failed |
The error (AFAICS) is from cross, furthermore, the image cross uses. This is rather frustrating but it is how things are right now. We'll need to provide (or find) images for cross that has our needs. See cross-rs/cross#164 (comment) for why we're not updating glibc in "official" cross images. As for where this error comes from, I'm not sure. Could be I think this is something we need to prioritize for svd2rust, as it's currently the biggest blocker for PRs. May be something for 2019 tools team objectives. |
TBH I've no idea why we need this amount of magic and fluff anyway instead of simply using the standard rust toolchain to test compile the generated PACs. |
I see two solutions:
|
While cross-compilation is nice and very useful, I don't really get why we to support cross-compilation for ancient or nostalgic targets. If someone wants to build for CentOS 7 why not use a CentOS 7 docker container and compile natively? |
@therealprof No, Centos 7 is too modern, we need Centos 5 😄 |
Withdrawing due to #297 fixing the issue. |
No description provided.