Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use Cargo instead of Cross #297

Merged
merged 3 commits into from
May 21, 2019
Merged

CI: use Cargo instead of Cross #297

merged 3 commits into from
May 21, 2019

Conversation

japaric
Copy link
Member

@japaric japaric commented May 21, 2019

this removes the Linux GNU targets used to produce binaries but we still have
the MUSL builds which will work everywhere because they statically linked
binaries

@japaric
CI: use Cargo instead of Cross
61a7aa6 
this removes the Linux GNU targets used to produce binaries but we still have
the MUSL builds which will work everywhere because they statically linked
binaries
@japaric japaric requested a review from a team as a code owner May 21, 2019 18:51
@rust-highfive
Copy link

r? @Emilgardis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels May 21, 2019
@jamesmunns
Copy link
Member

bors try

bors bot added a commit that referenced this pull request May 21, 2019
@bors
Try #297:
25d1610
@japaric japaric mentioned this pull request May 21, 2019
Closed
@bors
Copy link
Contributor

bors bot commented May 21, 2019

try

Build failed

@japaric
Copy link
Member Author

japaric commented May 21, 2019

Forgot the rust target add in ci/install.sh.

@therealprof
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 21, 2019
@bors
Try #297:
18db37d
@bors
Copy link
Contributor

bors bot commented May 21, 2019

try

Build failed

@japaric
Copy link
Member Author

japaric commented May 21, 2019

error occurred: Failed to find tool. Is musl-gcc installed?

This package is not the package whitelist. Let's skip the musl builds on CI; we can build the binary releases locally and upload the binaries.

https://travis-ci.org/rust-embedded/svd2rust/jobs/535456598

A network error ...

@therealprof
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 21, 2019
@bors
Try #297:
c3e3852
@bors
Copy link
Contributor

bors bot commented May 21, 2019

try

Build succeeded

therealprof
therealprof approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo! We're building again!

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request May 21, 2019
@bors @japaric
Merge #297
7266b41 
297: CI: use Cargo instead of Cross r=therealprof a=japaric

this removes the Linux GNU targets used to produce binaries but we still have
the MUSL builds which will work everywhere because they statically linked
binaries

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented May 21, 2019

Build succeeded

@bors bors bot merged commit 10d2ef9 into master May 21, 2019
@bors bors bot deleted the rm-cross branch May 21, 2019 22:12
@therealprof therealprof mentioned this pull request May 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@Emilgardis Emilgardis

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@japaric @rust-highfive @jamesmunns @therealprof @Emilgardis