-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new release that includes the libgit2 fixes #10446
Comments
See also [1][2]. Fixes #307. [1] rust-lang/git2-rs#813 [2] rust-lang/cargo#10446
Also affected, @Frederick888 did that downgrade patch you did on It seems like besides the immediate fix of getting everybody on the save version of libgit2, this is a bit of a bug in the whole ecosystem. Why is it even possible to build something depending on both cargo and libgit2-sys in such a way that is just going to segfault? |
No :( I thought I magically fixed it somehow cos my debug build didn't segfault, but If this is really urgent, I guess you can vendor a copy of patched |
Note: |
@Mark-Simulacrum any chance for a 0.61.1 release that contains this fix? A lot of cargo plugins are broken on distros with a recent libgit2 😕 |
The Cargo team would need to decide whether that makes sense ultimately. To clarify, we'd just need a crates.io release, right? The published cargo binaries built on our infrastructure aren't affected by this? That makes it pretty easy to do a backport and release I think. |
I think so, yes. |
We'd be fine making a new release. Someone needs to post a PR to backport the change to the |
I have published v0.61.1. |
Problem
The currently released cargo version transitively depends on a
libgit2-sys
version that segfault in combination with the current stablelibgit2
release (1.4.2). This was fixed in #10442, but wasn't released yet.Because projects can only link against one version of a
-sys
crate, projects that depend oncargo
cannot bump the dependencies themselves, because otherwise there is a linker conflict.Affected projects are cargo-outdated, cargo-crev and others. All these projects segfault when being used on an up-to-date Arch Linux system, and the maintainers of these cargo plugins can't do anything about it until a new
cargo
release is out.Steps
cargo-outdated
on an up to date Arch Linux systemcargo outdated
in a repository that contains git dependenciesPossible Solution(s)
Publish a new patch release containing the fix from #10442.
Notes
No response
Version
The text was updated successfully, but these errors were encountered: