-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in cargo 1.26.0-nightly 2018-04-04: [target.'cfg(FLAG)'.dependencies]
does not work anymore
#5313
Comments
Thanks for the report! Would it be possible to minimize this a bit to remove some of the intermediate dependencies. A simple test locally shows that this didn't trivially regress at least, but I may be missing something! |
Yes of course! I thought it was as simple as it looked but if not, I'll look into it. I'll report back with my findings. |
@alexcrichton - I think I'm seeing the same thing, simple repro on Windows here, just move Build with: (My scenario is the opposite - the file isn't missing, but it isn't getting included in the pdb.) Change I think I see this in |
Will look into this today! |
@lzybkr are you sure it is a regression? It looks like features are not supported in |
Reproduced
|
Ok, I believe this is caused by: #5249. Even if host == target, they differ in RUSTFLAGS (because only target gets them), so that optimization is incorrect. We can safely revert it though, because we now cache rustc anyway. |
@matklad - I was doing something new, it didn't work, and I found this issue when looking to see if the issue was known, so it might not be a regression. I was just looking for any way to pass a linker flag (not a path or lib) to a specific invocation of the compiler. |
One hard cs problem Closes #5313 r? @alexcrichton Note that, due to the first commit, this still gives us all the benefits of #5249: if RUSTFLAGS is empty, we will run only a single rustc process, even if we can't cache it across different cargo invocations.
I can confirm that it's indeed fixed. |
The new revision of cargo included in rust nightly has a regression.
My crate honggfuzz-rs is tested on travis daily and today the compilation failed even though there wasn't any commit:
https://travis-ci.org/rust-fuzz/honggfuzz-rs/builds/363265565
I suspect the regression comes from this line in my cargo.toml:
Code including
memmap
is only compiled when building with--cfg fuzzing_debug
and until now, this crate was accordingly also only included when building with this flag.It seems that this dependency is not understood anymore on the latest nightly.
I guess very few people/crates will be affected by this change/regression. For the record, I just want to state that I really don't care if it is decided that this functionality is not supported anymore.
The text was updated successfully, but these errors were encountered: