One hard cs problem #5389
Merged
One hard cs problem #5389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if we've failed to calculate fingerprint and thus can't persist cache to disk, it is still valid to cache rustc output within single process.
The info might be different due to RUSTFLAGS, which, in general, are applied only to target.
|
@bors: r+ |
|
📌 Commit f7fa1f2 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 18, 2018
One hard cs problem Closes #5313 r? @alexcrichton Note that, due to the first commit, this still gives us all the benefits of #5249: if RUSTFLAGS is empty, we will run only a single rustc process, even if we can't cache it across different cargo invocations.
|
☀️ Test successful - status-appveyor, status-travis |
matklad
added a commit
to matklad/rust
that referenced
this pull request
Apr 21, 2018
Some noteble changes: * regression fix: rust-lang/cargo#5390 * potentially breaking bug-fix: rust-lang/cargo#5389 * Cargo now caches the result of `rustc -vV`. It checks `rustc` binary mtime and rustup toolchain settings, so it should probably "just work" with rustbuild.
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 22, 2018
Update Cargo Some noteble changes: * ~~regression fix: rust-lang/cargo#5390 * ~~potentially breaking bug-fix: rust-lang/cargo#5389 * ~~Cargo now caches the result of `rustc -vV`. It checks `rustc` binary mtime and rustup toolchain settings, so it should probably "just work" with rustbuild.~~ potentially breaking bug-fix: rust-lang/cargo#5390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5313
r? @alexcrichton
Note that, due to the first commit, this still gives us all the benefits of #5249: if RUSTFLAGS is empty, we will run only a single rustc process, even if we can't cache it across different cargo invocations.