Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build::close_output occasionally fails on Rust CI #8665

Closed
tmiasko opened this issue Aug 31, 2020 · 3 comments · Fixed by #8668
Closed

build::close_output occasionally fails on Rust CI #8665

tmiasko opened this issue Aug 31, 2020 · 3 comments · Fixed by #8668
Labels
C-bug Category: bug

Comments

@tmiasko
Copy link
Contributor

tmiasko commented Aug 31, 2020 •
edited
Loading

For example, recent failures:

---- build::close_output stdout ----
thread 'build::close_output' panicked at 'lines differ:
   Compiling foo v0.1.0 (/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/cit/t216/foo)
error: Broken pipe (os error 32)
warning: build failed, waiting for other jobs to finish...
hello stderr!
error: build failed
', src/tools/cargo/tests/testsuite/build.rs:5043:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This might be related to changes to LineWriter backing stdout in the standard library. Previously, it used to ignore first encountered I/O error, now it should report it immediately.
@tmiasko tmiasko added the C-bug Category: bug label Aug 31, 2020
@alexcrichton
Copy link
Member

This was tweaked recently in #8587, can you see whether that PR was included in that failing CI run?

@tmiasko
Copy link
Contributor Author

tmiasko commented Aug 31, 2020

Yes, it is included already (based on line number from the error message build.rs:5043:5).

@tmiasko
Copy link
Contributor Author

tmiasko commented Aug 31, 2020

I can reproduce this locally, but only with recent rustc (not yet available from nightly). Pretty sure the issue has been exposed by recent changes mentioned earlier, since failures are now quite frequent.

@alexcrichton alexcrichton mentioned this issue Aug 31, 2020
Merged
bors added a commit that referenced this issue Aug 31, 2020
@bors
Auto merge of #8668 - alexcrichton:fix-close-output, r=ehuss
126907a 
Fix flakiness in close_output test

It looks like stdout/stderr can race as to which gets printed first, but
both are valid for this test.

Closes #8665
@bors bors closed this as completed in bf10871 Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flakiness in close_output test alexcrichton/cargo
2 participants
@alexcrichton @tmiasko