Fix flakiness in close_output test #8668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like stdout/stderr can race as to which gets printed first, but both are valid for this test. Closes rust-lang#8665
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! Sorry this test has been so finicky. For reference, this is likely caused by rust-lang/rust#72808. I don't fully understand that PR, but it seems plausible that the order would change if stdout is now block-buffered. @bors r+ |
|
📌 Commit bf10871 has been approved by |
bors
added
S-waiting-on-bors
|
Oh wow that does look like a gnarly PR... I think this was theoretically possible to happen previously as well, though. It's possible that Cargo read stdout first before stderr and passed it along, failing to write that and then later receiving stderr (or so I think). In any case seems fine either way. |
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2020
Update cargo 8 commits in 51b66125ba97d2906f461b3f4e0408f206299bb6..126907a7cfccbe93778530e6a6bbaa3adb6c515c 2020-08-19 20:22:52 +0000 to 2020-08-31 20:42:11 +0000 - Fix flakiness in close_output test (rust-lang/cargo#8668) - Reload unstable table from config file in `reload_rooted_at` (rust-lang/cargo#8656) - Bump to 0.49.0, update changelog (rust-lang/cargo#8659) - Fix LTO with doctests. (rust-lang/cargo#8657) - Add spaces after -C and -Z flags for consistency (rust-lang/cargo#8648) - Fix cache_messages::rustdoc test broken on beta. (rust-lang/cargo#8653) - fix: remove unnecessary allocations (rust-lang/cargo#8641) - Fixed a spelling and some clippy warnings (rust-lang/cargo#8637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like stdout/stderr can race as to which gets printed first, but
both are valid for this test.
Closes #8665