Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mdBook #8726

Closed
camelid opened this issue Sep 23, 2020 · 7 comments
Closed

Update mdBook #8726

camelid opened this issue Sep 23, 2020 · 7 comments

Comments

@camelid
Copy link
Member

camelid commented Sep 23, 2020 •
edited
Loading

Currently on version 0.3.7 and the newest version is 0.4.3, so there are breaking changes.

Relevant file:

cargo/.github/workflows/main.yml

Lines 97 to 100 in 13b73cd

- run: |
mkdir mdbook
curl -Lf https://github.com/rust-lang/mdBook/releases/download/v0.3.7/mdbook-v0.3.7-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=./mdbook
echo ::add-path::`pwd`/mdbook

@camelid
Copy link
Member Author

camelid commented Sep 23, 2020

Also, why are we not using cargo install?

@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2020

Error: The feature relabel is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please let @rust-lang/release know if you're having trouble with this bot.

@ehuss
Copy link
Contributor

ehuss commented Sep 23, 2020

The version shouldn't matter, it is only used for linkchecking. As for installation, downloading the binary is significantly faster.

@camelid
Copy link
Member Author

camelid commented Sep 23, 2020

The version shouldn't matter, it is only used for linkchecking.

Ah okay, I didn't notice that.

As for installation, downloading the binary is significantly faster.

Oops, I forgot that cargo install builds from source :)

@camelid
Copy link
Member Author

camelid commented Sep 23, 2020

Where is the book actually built for the website then?

@ehuss
Copy link
Contributor

ehuss commented Sep 23, 2020

All the books are built in the rust-lang/rust repo as part of the normal build. The code is in bootstrap, and can be built with commands like x.py doc src/tools/cargo/src/doc (though it is extremely rare anyone needs to do that manually).

@camelid
Copy link
Member Author

camelid commented Sep 23, 2020

Okay, thanks! I'll close this issue then and do it upstream.

@camelid camelid closed this as completed Sep 23, 2020
@dtolnay dtolnay mentioned this issue Dec 18, 2022
Merged
bors added a commit that referenced this issue Dec 18, 2022
@bors
Auto merge of #11498 - dtolnay-contrib:relabel, r=ehuss
9f4efa5 
Enable triagebot's relabel functionality

### What does this PR try to resolve?

This fixes the following failure that rustbot currently posts whenever someone tries to use "<b>`@</b><b>rustbot</b>` label" in this repository.

> **Error**: The feature `relabel` is not enabled in this repository.
> To enable it add its section in the `triagebot.toml` in the root of the repository.

Unauthenticated relabel has been enabled in rust-lang/rust for nearly 4 years. People overwhelmingly use it in good faith.

<br>

### How should we test and review this PR?

Compare against https://github.com/rust-lang/rust/blob/1.66.0/triagebot.toml.

Also skim through the 7 pages of labels on https://github.com/rust-lang/cargo/labels, whether it makes sense the ones I decided to allow arbitrary GitHub users to apply.

<br>

### Additional information

Attempted uses of "<b>`@</b><b>rustbot</b>` label", that failed, but this PR would allow:

- #10343 (comment)
- #10243 (comment)
- #9982 (comment)
- #9128 (comment)
- #9067 (comment)
- #8441 (comment)
- #11432 (comment)
- #8841 (comment)
- #10820 (comment)
- #10572 (comment)
- #9114 (comment)
- #8980 (comment)
- #9064 (comment)
- #8726 (comment)
- #8089 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ehuss @camelid @rustbot