Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misspelling of environment variable #9067

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Fix misspelling of environment variable #9067

merged 1 commit into from
Jan 12, 2021

Conversation

AnthonyMikh
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 12, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 12, 2021

📌 Commit 7bec315e8ba1d2962d580cf0f18766b96c863a3a has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2021
@bors
Copy link
Collaborator

bors commented Jan 12, 2021

⌛ Testing commit 7bec315e8ba1d2962d580cf0f18766b96c863a3a with merge 89801a3d6307fa96c50cf052657eba0325b26a93...

@bors
Copy link
Collaborator

bors commented Jan 12, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2021
@ehuss
Copy link
Contributor

ehuss commented Jan 12, 2021

The man pages need to be rebuilt. Go to the src/doc directory and run the ./build-man.sh script (documented here).

@ehuss ehuss added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2021
@AnthonyMikh
Copy link
Contributor Author

@ehuss Thank you for your guidance.

@rustbot modify labels: -S-waiting-on-author

@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2021

Error: The feature relabel is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please let @rust-lang/release know if you're having trouble with this bot.

@ehuss
Copy link
Contributor

ehuss commented Jan 12, 2021

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 12, 2021

📌 Commit 159e88a has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Jan 12, 2021
@bors
Copy link
Collaborator

bors commented Jan 12, 2021

⌛ Testing commit 159e88a with merge 7f41cf6...

@bors
Copy link
Collaborator

bors commented Jan 12, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 7f41cf6 to master...

@bors bors merged commit 7f41cf6 into rust-lang:master Jan 12, 2021
@AnthonyMikh AnthonyMikh deleted the patch-1 branch January 12, 2021 23:46
@ehuss ehuss mentioned this pull request Jan 13, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 15, 2021
@bors
Auto merge of rust-lang#80974 - ehuss:update-cargo, r=ehuss
e48eb37 
Update cargo

10 commits in 329895f5b52a358e5d9ecb26215708b5cb31d906..a73e5b7d567c3036b296fc6b33ed52c5edcd882e
2021-01-06 00:01:52 +0000 to 2021-01-12 23:45:39 +0000
- Sort available binaries when multiple (rust-lang/cargo#9066)
- Fix misspelling of environment variable (rust-lang/cargo#9067)
- Remove statement that opt-level 0 turns on debug (rust-lang/cargo#9070)
- Fix `links` vars showing up for testing packages (rust-lang/cargo#9065)
- Fix unit_for computation on proc-macros in shared workspace. (rust-lang/cargo#9059)
- Document `could not find the github team` error on `cargo owner --add` (rust-lang/cargo#9000)
- Unstable section of cargo/config.toml takes bools (rust-lang/cargo#9057)
- [doc] add note about empty environment variables for missing manifest keys (rust-lang/cargo#9053)
- another round of clippy lint fixes (rust-lang/cargo#9051)
- Updated display message of cargo metadata --help (rust-lang/cargo#9050)
@ehuss ehuss added this to the 1.51.0 milestone Feb 6, 2022
@dtolnay dtolnay mentioned this pull request Dec 18, 2022
Merged
bors added a commit that referenced this pull request Dec 18, 2022
@bors
Auto merge of #11498 - dtolnay-contrib:relabel, r=ehuss
9f4efa5 
Enable triagebot's relabel functionality

### What does this PR try to resolve?

This fixes the following failure that rustbot currently posts whenever someone tries to use "<b>`@</b><b>rustbot</b>` label" in this repository.

> **Error**: The feature `relabel` is not enabled in this repository.
> To enable it add its section in the `triagebot.toml` in the root of the repository.

Unauthenticated relabel has been enabled in rust-lang/rust for nearly 4 years. People overwhelmingly use it in good faith.

<br>

### How should we test and review this PR?

Compare against https://github.com/rust-lang/rust/blob/1.66.0/triagebot.toml.

Also skim through the 7 pages of labels on https://github.com/rust-lang/cargo/labels, whether it makes sense the ones I decided to allow arbitrary GitHub users to apply.

<br>

### Additional information

Attempted uses of "<b>`@</b><b>rustbot</b>` label", that failed, but this PR would allow:

- #10343 (comment)
- #10243 (comment)
- #9982 (comment)
- #9128 (comment)
- #9067 (comment)
- #8441 (comment)
- #11432 (comment)
- #8841 (comment)
- #10820 (comment)
- #10572 (comment)
- #9114 (comment)
- #8980 (comment)
- #9064 (comment)
- #8726 (comment)
- #8089 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
6 participants
@AnthonyMikh @rust-highfive @alexcrichton @bors @ehuss @rustbot