Warning when precise or aggressive without -p flag #10988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
epage
reviewed
Aug 15, 2022
weihanglo
reviewed
Aug 15, 2022
Rustin170506
force-pushed
the
rustin-patch-warn
branch
from
28b3b89 to
784ddcc
Compare
|
Thanks for your review! 💚 💙 💜 💛 ❤️ |
Rustin170506
force-pushed
the
rustin-patch-warn
branch
3 times, most recently
from
19816b5 to
b6de8b4
Compare
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Rustin170506
force-pushed
the
rustin-patch-warn
branch
from
b6de8b4 to
a58489d
Compare
epage
approved these changes
Aug 17, 2022
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Aug 22, 2022
Add more tests for aggressive or precise update ### What does this PR try to resolve? When I was working on #10988, I found there is no test for the aggressive update. So I added it. Also, I added a test for precise update to make sure it won't force update the deps of SPEC. ### How should we test and review this PR? Unit tests.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 24, 2022
Update cargo 7 commits in 9809f8ff33c2b998919fd0432c626f0f7323697a..6da726708a4406f31f996d813790818dce837161 2022-08-16 22:10:06 +0000 to 2022-08-23 21:39:56 +0000 - Update non-ASCII crate name warning message (rust-lang/cargo#11017) - Add more tests for aggressive or precise update (rust-lang/cargo#11011) - Ignore broken but excluded file during traversing (rust-lang/cargo#11008) - Improve error message for wrong target names (rust-lang/cargo#10999) - Bump snapbox to 0.3 (rust-lang/cargo#11005) - remove missed reference to workspace inheritance in unstable.md (rust-lang/cargo#11001) - Warning when precise or aggressive without -p flag (rust-lang/cargo#10988)
bors
added a commit
that referenced
this pull request
Nov 30, 2022
Error when precise without -p flag ### What does this PR try to resolve? close #10919 Follow up #10988, see #10919 (comment) ### How should we test and review this PR? You can manually build and test it. You can try `cargo update --precise xxx` without -p flag. ### Additional information It has already been released on stable. `rustc 1.65.0 (897e37553 2022-11-02)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
ref #10919.
Warning when precise or aggressive without -p flag. It will be a hard error in future.
How should we test and review this PR?