Update non-ASCII crate name warning message #11017
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
| @@ -253,8 +253,7 @@ fn check_name( | |||
| if restricted_names::is_non_ascii_name(name) { | |||
| shell.warn(format!( | |||
| "the name `{}` contains non-ASCII characters\n\ | |||
| Support for non-ASCII crate names is experimental and only valid \ | |||
| on the nightly toolchain.", | |||
| Non-ASCII crate names are not supported by Rust.", | |||
There was a problem hiding this comment.
I think this should say cargo not Rust since it is emitted by cargo
| Non-ASCII crate names are not supported by Rust.", | |
| Non-ASCII crate names are not supported by cargo.", |
There was a problem hiding this comment.
I had also considered that but currently Cargo does support non-ASCII crates without much issue. Its just rustc that doesn't. For example, this works fine with cargo check:
[dependencies]
"ああああ" = { path = "../ああああ" }
There was a problem hiding this comment.
I am not sure whether it's too much, but I might put something like "it will become a hard error in a future release" if we are trying to scare away folks using non-ASCII crate name 😆.
Either way, they will evenutually figure out it won't work when using as an extern crate (dependency).
There was a problem hiding this comment.
Personally, I wouldn't mind if Cargo still supported it so that you could make binaries with non-ASCII names, regardless of how well everything else on the system handles it :D
| @@ -253,8 +253,7 @@ fn check_name( | |||
| if restricted_names::is_non_ascii_name(name) { | |||
| shell.warn(format!( | |||
There was a problem hiding this comment.
I am wondering if this should be a warning or an error. To me, it seems like it should be an error but one of the cargo team members may have a different idea.
There was a problem hiding this comment.
Such a package rename still works. I feel like changing it to hard error is a bit rush at this moment.
[dependencies]
hello = { path = "./你好", package = "你好" }
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Update cargo 7 commits in 9809f8ff33c2b998919fd0432c626f0f7323697a..6da726708a4406f31f996d813790818dce837161 2022-08-16 22:10:06 +0000 to 2022-08-23 21:39:56 +0000 - Update non-ASCII crate name warning message (rust-lang/cargo#11017) - Add more tests for aggressive or precise update (rust-lang/cargo#11011) - Ignore broken but excluded file during traversing (rust-lang/cargo#11008) - Improve error message for wrong target names (rust-lang/cargo#10999) - Bump snapbox to 0.3 (rust-lang/cargo#11005) - remove missed reference to workspace inheritance in unstable.md (rust-lang/cargo#11001) - Warning when precise or aggressive without -p flag (rust-lang/cargo#10988)
This PR fixes an outdated warning when initializing crates sometimes.
What does this PR try to resolve?
Per a Zulip convo on the topic, non-ASCII crate names are no longer allowed on any toolchain since rust-lang/rust#73305, during the
non_ascii_identsfeature's development. Cargo however tells the user that they are accepted on Nightly. Rust and Cargo should agree on this point to avoid future confusion.How should we test and review this PR?
This should be covered by the existing test that was changed but if desired its easy to test with a checkout: