Fix a regression with parsing multivalue options #5196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, clap interprets ``` cargo run --bin foo bar baz ``` as ``` cargo run --bin foo --bin bar --bin baz ``` This behavior is different from docopt and does not play nicely with positional arguments at all. Luckily, clap has a flag to get the behavior we want, it just not the default! It will become the default in the next version of clap, but, until that time, we should be careful when using the combination of `.long`, `.value_name` and `.multiple(true)`, and don't forget to specify `.number_of_values(1)` as well.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
matklad
commented
Mar 16, 2018
| .arg("hello") | ||
| .arg("world"), | ||
| execs().with_status(0), | ||
| ); |
There was a problem hiding this comment.
Not related to the PR, but do you feel like making p.cargo a little bit more magical, so that
assert_that(
p.cargo("run --bin foo hello world"),
execs().with_status(0),
);
works?
There was a problem hiding this comment.
I'd be totally down for that!
|
@bors: r+ |
|
📌 Commit 70ff33a has been approved by |
bors
added a commit
that referenced
this pull request
Mar 16, 2018
Fix a regression with parsing multivalue options By default, clap interprets ``` cargo run --bin foo bar baz ``` as ``` cargo run --bin foo --bin bar --bin baz ``` This behavior is different from docopt and does not play nicely with positional arguments at all. Luckily, clap has a flag to get the behavior we want, it just not the default! It will become the default in the next version of clap, but, until that time, we should be careful when using the combination of `.long`, `.value_name` and `.multiple(true)`, and don't forget to specify `.number_of_values(1)` as well. @alexcrichton I'd love to merge this fix before updating cargo at rust-lang/rust :)
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Mar 16, 2018
Slightly improve ergonomics of writing Cargo tests As discussed in #5196 (comment) I've also employed this to some of the longer command-lines in our test suite :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, clap interprets
as
This behavior is different from docopt and does not play nicely with
positional arguments at all. Luckily, clap has a flag to get the
behavior we want, it just not the default! It will become the default in
the next version of clap, but, until that time, we should be careful
when using the combination of
.long,.value_nameand.multiple(true), and don't forget to specify.number_of_values(1)aswell.
@alexcrichton I'd love to merge this fix before updating cargo at rust-lang/rust :)