Slightly improve ergonomics of writing Cargo tests #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ Nice! |
|
📌 Commit 54d9968 has been approved by |
|
⌛ Testing commit 54d9968c847554afdd68ec944176569db8fd3a17 with merge e1d0926b2e51c898f0d0e6c54027a714ba77c29b... |
|
💔 Test failed - status-travis |
|
@bors: retry
…On Fri, Mar 16, 2018 at 12:32 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/354424128?utm_source=github_status&utm_medium=notification>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5197 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AdkLnNqWyw28VbANxZWSv9vh2C-ks5te_cdgaJpZM4SuIdc>
.
|
|
⌛ Testing commit 54d9968c847554afdd68ec944176569db8fd3a17 with merge 93475ff514f2fb0a6dbca4aae4aa876a531d5734... |
|
💔 Test failed - status-travis |
|
@bors r=alexcrichton Funny enough, the tests passed locally and here on travis, but not on bors, due to that regression with |
|
📌 Commit e5971b9 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 16, 2018
Slightly improve ergonomics of writing Cargo tests As discussed in #5196 (comment) I've also employed this to some of the longer command-lines in our test suite :)
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5196 (comment)
I've also employed this to some of the longer command-lines in our test suite :)