Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document cargo limitation w/ workspaces & configs #9674

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

iankronquist
Copy link
Contributor

This behavior is described in this bug:
#2930

I think we should document limitations of the tool which exist at present if they do not bind our hands in the future.
If this bug is fixed, this note should be removed.

This behavior is described in this bug:
rust-lang#2930

I think we should document limitations of the tool which exist at present if they do not bind our hands in the future.
If this bug is fixed, this note should be removed.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2021
@iankronquist
Copy link
Contributor Author

This change was made from the github editor, and not tested locally.

@alexcrichton
Copy link
Member

Thanks for this! I think this is probably good to clarify, but I think it's ok to happen outside of a quoted block (e.g. no >) since it's a pretty important explanation.

@iankronquist
Copy link
Contributor Author

Thanks for the advice, I've moved it outside a quoted block :)

@iankronquist
Copy link
Contributor Author

iankronquist commented Jul 13, 2021

Tying two separate thread together: another contributor says that it is currently documented on that page, ("It looks for configuration files in the current directory and all parent directories"), but I think we should document this caveat explicitly, which is why I opened this PR.

@alexcrichton
Copy link
Member

@bors: r+

Ok, thanks!

@bors
Copy link
Collaborator

bors commented Jul 15, 2021

📌 Commit d054652 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2021
@bors
Copy link
Collaborator

bors commented Jul 15, 2021

⌛ Testing commit d054652 with merge a2badc1...

@bors
Copy link
Collaborator

bors commented Jul 15, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing a2badc1 to master...

@bors bors merged commit a2badc1 into rust-lang:master Jul 15, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2021
Update cargo

6 commits in 66a6737a0c9f3a974af2dd032a65d3e409c77aac..27277d966b3cfa454d6dea7f724cb961c036251c
2021-07-14 20:54:28 +0000 to 2021-07-16 00:50:39 +0000
- Flag another curl error as possibly spurious (rust-lang/cargo#9695)
- Add `d` as an alias for `doc` (rust-lang/cargo#9680)
- `cargo fix --edition`: extend warning when on latest edition (rust-lang/cargo#9694)
- Update env_logger requirement from 0.8.1 to 0.9.0 (rust-lang/cargo#9688)
- Document cargo limitation w/ workspaces & configs (rust-lang/cargo#9674)
- Change some warnings to errors (rust-lang/cargo#9689)
@ehuss ehuss added this to the 1.55.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants