Fix compilation errors for Armv8-M Baseline and Mainline with FPU #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Armv8-M Baseline, ie thumbv8m.base-none-eabi, is a superset of the Armv6-M architecture profile. As it shares almost the same instruction set, this commit copies the configuration for thumbv6m-none-eabi to enable it.
Some files were not assembling for the Armv8-M Mainline architecture profile with FPU extension. Reason being the same as for Armv7-M: the conversion intrinsics including double precision floating point variables do not work with single precision FPUs. Also removes from exclusion files that are assembling without errors for Armv7-M and Armv8-M Mainline.
It seems that the intrinsics that were generated for the functions in example/intrinsics.rs where different implementations were given for thumb6m-none-eabi target, have now been implemented in Rust so configuration is not needed anymore.
|
LGTM, and travis is happy. |
|
Thanks @hug-dev! |
|
Thanks! |
|
We can make a release when necessary yeah, but for now you'll probably want to use |
|
Cool, will prepare the PR :) |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Mar 20, 2019
Add dist builder for Armv8-M Baseline and HF This commit adds the Armv8-M Baseline and Armv8-M Mainline with FPU targets in the list of targets that get their dist components built. It also update the build-manifest so that this target gets also its dist components uploaded. Made possible with the recent change merged in `compiler-builtins`: rust-lang/compiler-builtins#276 A new `compiler-builtins` might be necessary for successfull compilation of the artefacts of those targets.
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 3, 2019
Add dist builder for Armv8-M Baseline and HF This commit adds the Armv8-M Baseline and Armv8-M Mainline with FPU targets in the list of targets that get their dist components built. It also update the build-manifest so that this target gets also its dist components uploaded. Made possible with the recent change merged in `compiler-builtins`: rust-lang/compiler-builtins#276 A new `compiler-builtins` might be necessary for successfull compilation of the artefacts of those targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The larger goal of this pull request is to add
thumbv8m.base-none-eabiandthumbv8m.main-none-eabihftargets to the Rust CI so that the artefacts are available viarustupThis pull request specifically fixes the compilation errors encountered when compiling for those targets.
On the way, I added some modifications, not strictly related with those goals and that need to be checked:
arm-none-eabi-gccwith the same options used bycc-rsand it was working correctly. Maybe I am missing something on why are these files excluded?cfg(not(thumbv6m))from the intrinsics example as the "real" functions were compiling fine forthumbv6m(and then alsothumbv8m.base)? I suppose that the intrinsics were implemented for those targets after thecfgwas made. I suppose then that Operations not available on ARMv6-M targets #75 should be closed? Again, maybe I am missing something.I was not sure how to test it so I compiled the intrinsics example for the Arm targets:
Also I patched the Rust compiler with my local modified version of
compiler-builtinsand produced the distribution artefacts, successfully, for all the Arm targets again: