Add dist builder for Armv8-M Baseline and HF #59182
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@hug-dev want to switch the dist-various-1 builder in .travis.yml to working on the |
|
@alexcrichton Sure! Just to make sure is that that change: diff --git a/.travis.yml b/.travis.yml
index 7985b6c0e1..df1182345b 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -121,7 +121,7 @@ matrix:
- env: IMAGE=armhf-gnu
if: branch = auto
- env: IMAGE=dist-various-1 DEPLOY=1
- if: branch = auto
+ if: branch = try
- env: IMAGE=dist-various-2 DEPLOY=1
if: branch = auto
- env: IMAGE=dist-aarch64-linux DEPLOY=1 |
|
I believe that should do the trick yeah! |
|
@bors: try |
|
⌛ Trying commit c53546e445f993726a734b9e7571097cb9728ef3 with merge ba2183194c0e4a5e867f16c6f23714f0360e2ce9... |
|
Hm it looks like the job failed but for a different reason? Feel free to use |
|
💔 Test failed - checks-travis |
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #59298) made this pull request unmergeable. Please resolve the merge conflicts. |
Try a release for the rust-lang/rust#59182 PR to pull the new changes related with Armv8-M.
|
I rebased and added a new commit which replace @alexcrichton If all of this is correct, a new |
|
@bors: try |
Add dist builder for Armv8-M Baseline and HF This commit adds the Armv8-M Baseline and Armv8-M Mainline with FPU targets in the list of targets that get their dist components built. It also update the build-manifest so that this target gets also its dist components uploaded. Made possible with the recent change merged in `compiler-builtins`: rust-lang/compiler-builtins#276 A new `compiler-builtins` might be necessary for successfull compilation of the artefacts of those targets.
|
☀️ Try build successful - checks-travis |
|
Nice! The job has a bunch of verbose logs which point to: (and the final component can be tweaked to get the different targets) Mind poking around those and make sure they look all good? After that looks like this'll be an easy merge! (we can get the compiler-builtins changes in and published before this PR lands) |
|
I can not say if there are no bugs at all, but I think this is fine. |
|
Ok great! Want to send a PR to compiler-builtins and I can merge/publish? |
|
Sure! Do you mean a PR that does the same thing as this below to mark the new release? |
|
Oh sorry I thought there were more changes that weren't already in there. In that case I've published 0.1.8 now |
|
No worries! I am going to update this PR to remove the commits that use the |
|
📌 Commit c717cb09c6cd744bfb2769b51fa818a4c4644561 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #57810) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
Rebased to fix conflict on |
|
@bors: r+ |
|
📌 Commit d06683f4dfb3ee53c2a8c9bc0d70b960f0d41224 has been approved by |
bors
added
S-waiting-on-bors
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #59464) made this pull request unmergeable. Please resolve the merge conflicts. |
This commit adds the Armv8-M Baseline and Armv8-M Mainline with FPU targets in the list of targets that get their dist components built. It also update the build-manifest so that this target gets also its dist components uploaded.
|
Rebased and removed the |
|
@bors: r+ |
|
📌 Commit e833499 has been approved by |
bors
added
S-waiting-on-bors
Add dist builder for Armv8-M Baseline and HF This commit adds the Armv8-M Baseline and Armv8-M Mainline with FPU targets in the list of targets that get their dist components built. It also update the build-manifest so that this target gets also its dist components uploaded. Made possible with the recent change merged in `compiler-builtins`: rust-lang/compiler-builtins#276 A new `compiler-builtins` might be necessary for successfull compilation of the artefacts of those targets.
|
☀️ Test successful - checks-travis, status-appveyor |
The following targets are now built and distributed: - aarch64-unknown-none: rust-lang/rust#68334 - mips64-unknown-linux-muslabi64: rust-lang/rust#65843 - mips64el-unknown-linux-muslabi64: rust-lang/rust#65843 - nvptx64-nvidia-cuda: rust-lang/rust#57937 - riscv32i-unknown-none-elf: rust-lang/rust#62784 - riscv64gc-unknown-linux-gnu: rust-lang/rust#68037 - thumbv8m.base-none-eabi: rust-lang/rust#59182 - thumbv8m.main-none-eabi : rust-lang/rust#56954 - thumbv8m.main-none-eabihf: rust-lang/rust#59182
This commit adds the Armv8-M Baseline and Armv8-M Mainline with
FPU targets in the list of targets that
get their dist components built. It also update the build-manifest
so that this target gets also its dist components uploaded.
Made possible with the recent change merged in
compiler-builtins:rust-lang/compiler-builtins#276
A new
compiler-builtinsmight be necessary for successfull compilation of the artefacts of those targets.