tests/krate/publish: Use assert_eq!() to check response payload content
#3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to use the constant in tests
…stant This will allow us to use the constant in tests
…unction This will allow us to use the message generator function in tests
|
@bors r+ |
|
📌 Commit 191e1e5 has been approved by |
|
☀️ Test successful - checks-actions |
This was referenced Dec 13, 2020
bors
added a commit
that referenced
this pull request
Dec 22, 2020
tests: Use `assert_eq!()` to check error response payload content This PR continues #3066 and converts the remaining tests to use the same pattern of using `assert_eq!()` and the `json!()` macro to assert on the exact structure and content of the error responses. r? `@jtgeibel`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
json!()macro makes it quite straight forward to assert against the exact response payload expectation and is ultimately less verbose than checking againstjson.errors[0].detaillike we currently do.r? @jtgeibel