-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save original dependency requirement string in the database when publishing #3049
Conversation
☔ The latest upstream changes (presumably #3051) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
☔ The latest upstream changes (presumably #3062) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
☔ The latest upstream changes (presumably #3066) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
@bors r+ |
📌 Commit 815a218 has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
… functions This allows us to generate payload with invalid JSON
…:version/dependencies`
@bors r=jtgeibel |
📌 Commit c50c536 has been approved by |
☀️ Test successful - checks-actions |
This PR should resolve #3047 by saving the original dependency requirement string in the database when publishing, and returning the original string too when calling the
GET /crates/:crate_id/:version/dependencies
endpoint.Before #2990 we were turning
1.2.3
into^1.2.3
automatically. After that PR were turning it into>=1.2.3, <2.0.0
, and now, with this PR, we would keep it at1.2.3
and it would be up to the API client to prefix the^
, if necessary.r? @jtgeibel
/cc @dtolnay