Refactor some test code #3391
Merged
Refactor some test code #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The good method is extracted to its own impl block, as other methods do not require this constraint.
|
yes, please!! 👍 @bors r+ |
|
📌 Commit 9e15c20 has been approved by |
|
☀️ Test successful - checks-actions |
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is best to review per-commit, as some logic is split into sub-modules under
utilwhich obscures the smaller diffs within. The individual commits should all be straightforward.In particular, many
T: serde::Deserializebounds are removed from various test helper methods, which allowed some remaining on-off tests to switch over to the test helpers.r? @Turbo87