Prep for semver bump and document current blocker #3338
Conversation
|
looks like CI is unhappy 😢 |
jtgeibel
force-pushed
the
bring-back-latest-semver
branch
from
d7c8b58 to
eb8b0ac
Compare
|
Forgetting to |
|
you linked #3094 in the description, but I'm assuming that was a typo, right? 🤔 |
|
I believe dtolnay/semver#217 might still be blocking this |
Turbo87
added
A-backend ⚙️
C-internal 🔧
This (partially) reverts commit 0bcb724. This partially reverts the revert (rust-lang#3051) of rust-lang#2990. While we can't bump the version yet, it is worth recovering these changes and documenting the remaining work.
jtgeibel
force-pushed
the
bring-back-latest-semver
branch
from
eb8b0ac to
3b9594c
Compare
jtgeibel
changed the title
|
@Turbo87 I've rolled back the version bump and added a comment pointing to the blocker. I've updated the PR title and description to reflect the new scope. |
I plan to eventually land additional tests upstream. For now, this provides a convenient way to ensure we don't regress on parsing these formats.
|
@Turbo87 I've added a test that covers some scenarios where I observed breakage. I'll probably move this test upstream eventually, but it is worth including here for now. I've also added a command to the |
| let vers = versions.select(num).load(&conn)?; | ||
| test_versions(&vers); | ||
|
|
||
| let deps = dependencies.select(req).load(&conn)?; |
There was a problem hiding this comment.
I'm not entirely sure about loading all dependencies in a single query, but this is against the replica database and I expect memory usage to be somewhere around 100 MB so I think this is okay for our current scale.
| for version in versions { | ||
| if let Err(e) = semver::Version::parse(version) { | ||
| println!("Could not parse `{}` as a semver::Version: {}", version, e); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
| for version in versions { | |
| if let Err(e) = semver::Version::parse(version) { | |
| println!("Could not parse `{}` as a semver::Version: {}", version, e); | |
| } | |
| } |
this looks like a duplicate to me, no?
| fn test_dependency_predicates(versions: &[String]) { | ||
| for version in versions { | ||
| if let Err(e) = semver::VersionReq::parse(version) { | ||
| println!("Could not parse `{}` as a semver::Version: {}", version, e); |
There was a problem hiding this comment.
| println!("Could not parse `{}` as a semver::Version: {}", version, e); | |
| println!("Could not parse `{}` as a semver::VersionReq: {}", version, e); |
|
|
||
| if let Err(e) = semver_next::VersionReq::parse(version) { | ||
| println!( | ||
| "Could not parse `{}` as a semver_next::Version: {}", |
There was a problem hiding this comment.
| "Could not parse `{}` as a semver_next::Version: {}", | |
| "Could not parse `{}` as a semver_next::VersionReq: {}", |
|
☔ The latest upstream changes (presumably #3391) made this pull request unmergeable. Please resolve the merge conflicts. |
This partially reverts the revert (#3051) of #2990. While we can't bump the version yet, it is worth recovering these changes and documenting the remaining work.
r? @Turbo87