Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom indexes #1140

Merged
merged 6 commits into from
Oct 30, 2020
Merged

Support custom indexes #1140

merged 6 commits into from
Oct 30, 2020

Conversation

l4l
Copy link
Contributor

@l4l l4l commented Oct 29, 2020

Resolves #767

@jyn514 jyn514 added A-builds Area: Building the documentation for a crate S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 29, 2020
jyn514
jyn514 reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really cool :D thanks for working on this!

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/bin/cratesfyi.rs Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
l4l and others added 3 commits October 30, 2020 02:54
@l4l l4l force-pushed the custom-index-location branch from 17e1f89 to a92835b Compare October 30, 2020 12:42
@l4l l4l force-pushed the custom-index-location branch from a92835b to 26a764f Compare October 30, 2020 13:19
jyn514
jyn514 approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I tested that both the daemon and stand-alone builds still work without a registry url set.

src/bin/cratesfyi.rs Outdated Show resolved Hide resolved
@jyn514 jyn514 added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 30, 2020
@jyn514 jyn514 merged commit dbbb5a1 into rust-lang:master Oct 30, 2020
This was referenced Oct 30, 2020
Merged
Closed
@l4l l4l deleted the custom-index-location branch October 30, 2020 18:19
@jyn514 jyn514 removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietroalbini pietroalbini pietroalbini left review comments

@jyn514 jyn514 jyn514 approved these changes

Assignees
No one assigned
Labels
A-builds Area: Building the documentation for a crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable index location
3 participants
@l4l @pietroalbini @jyn514