Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support custom indexes" #1147

Merged
merged 6 commits into from
Oct 30, 2020
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Oct 30, 2020

Reverts #1140

This caused a production outage:

Oct 30 15:42:52 docsrs cratesfyi[8350]: Error: initialising registry index repository
Oct 30 15:42:52 docsrs cratesfyi[8350]: Caused by:
Oct 30 15:42:52 docsrs cratesfyi[8350]:     Actual 'origin' remote url "https://github.com/rust-lang/crates.io-index.git" did not match desired one at "https://github.com/rust-lang/crates.io-index"
Oct 30 15:42:52 docsrs cratesfyi[8350]: Stack backtrace:
Oct 30 15:42:52 docsrs cratesfyi[8350]:    0: failure::backtrace::internal::InternalBacktrace::new
Oct 30 15:42:52 docsrs cratesfyi[8350]:    1: failure::backtrace::Backtrace::new
Oct 30 15:42:52 docsrs cratesfyi[8350]:    2: docs_rs::index::Index::new
Oct 30 15:42:52 docsrs cratesfyi[8350]:    3: once_cell::imp::OnceCell<T>::initialize
Oct 30 15:42:52 docsrs cratesfyi[8350]:    4: <cratesfyi::BinContext as docs_rs::context::Context>::index
Oct 30 15:42:52 docsrs cratesfyi[8350]:    5: docs_rs::utils::daemon::start_daemon
Oct 30 15:42:52 docsrs cratesfyi[8350]:    6: cratesfyi::CommandLine::handle_args
Oct 30 15:42:52 docsrs cratesfyi[8350]:    7: cratesfyi::main
Oct 30 15:42:52 docsrs cratesfyi[8350]:    8: std::rt::lang_start::{{closure}}
Oct 30 15:42:52 docsrs cratesfyi[8350]:    9: std::rt::lang_start_internal::{{closure}}
Oct 30 15:42:52 docsrs cratesfyi[8350]:              at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/rt.rs:52
Oct 30 15:42:52 docsrs cratesfyi[8350]:       std::panicking::try::do_call
Oct 30 15:42:52 docsrs cratesfyi[8350]:              at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/panicking.rs:297
Oct 30 15:42:52 docsrs cratesfyi[8350]:       std::panicking::try
Oct 30 15:42:52 docsrs cratesfyi[8350]:              at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/panicking.rs:274
Oct 30 15:42:52 docsrs cratesfyi[8350]:       std::panic::catch_unwind
Oct 30 15:42:52 docsrs cratesfyi[8350]:              at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/panic.rs:394
Oct 30 15:42:52 docsrs cratesfyi[8350]:       std::rt::lang_start_internal
Oct 30 15:42:52 docsrs cratesfyi[8350]:              at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/rt.rs:51
Oct 30 15:42:52 docsrs cratesfyi[8350]:   10: main

cc @l4l

@jyn514
Copy link
Member Author

jyn514 commented Oct 30, 2020

This revert has already been deployed in production.

@jyn514 jyn514 merged commit 5085d57 into master Oct 30, 2020
@jyn514 jyn514 deleted the revert-1140-custom-index-location branch October 30, 2020 15:49
@jyn514
Copy link
Member Author

jyn514 commented Oct 30, 2020

@Nemo157 and I debugged this: you can replicate the failure locally with git remote set-url origin https://github.com/rust-lang/crates.io-index.git and running cargo run daemon. The issue was the crates-index-diff update, not the code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant