Various fixes too make the CI green #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkratz
changed the title
cfg condition name: nightlycfg condition name: ...
hkratz
force-pushed
the
fix-ci
branch
2 times, most recently
from
5e19314 to
1be6431
Compare
hkratz
changed the title
cfg condition name: ...
hkratz
force-pushed
the
fix-ci
branch
2 times, most recently
from
aa9beae to
9a7f63e
Compare
taiki-e
reviewed
Sep 14, 2024
…er unexpected config
taiki-e
approved these changes
Sep 14, 2024
taiki-e
pushed a commit
that referenced
this pull request
Oct 5, 2024
* Fix unexpected `cfg` condition name: ... warnings introduced in Rust 1.80 See https://blog.rust-lang.org/2024/05/06/check-cfg.html * io_slice_advance feature is now stable * clippy: enable missing_const_for_thread_local lint, now checks for MSRV (see rust-lang/rust-clippy#12404) * clippy: fixes for "doc list item without indentation" lint * clippy: ignore incorrect "first doc comment paragraph is too long" warning see rust-lang/rust-clippy#13315 * clippy: allow long first paragraphs in select... fn doc comments * use workspace level setting to ignore error about the futures_sanitizer unexpected config
Merged
taiki-e
pushed a commit
that referenced
this pull request
Oct 5, 2024
* Fix unexpected `cfg` condition name: ... warnings introduced in Rust 1.80 See https://blog.rust-lang.org/2024/05/06/check-cfg.html * io_slice_advance feature is now stable * clippy: enable missing_const_for_thread_local lint, now checks for MSRV (see rust-lang/rust-clippy#12404) * clippy: fixes for "doc list item without indentation" lint * clippy: ignore incorrect "first doc comment paragraph is too long" warning see rust-lang/rust-clippy#13315 * clippy: allow long first paragraphs in select... fn doc comments * use workspace level setting to ignore error about the futures_sanitizer unexpected config
taiki-e
pushed a commit
that referenced
this pull request
Oct 5, 2024
* Fix unexpected `cfg` condition name: ... warnings introduced in Rust 1.80 See https://blog.rust-lang.org/2024/05/06/check-cfg.html * io_slice_advance feature is now stable * clippy: enable missing_const_for_thread_local lint, now checks for MSRV (see rust-lang/rust-clippy#12404) * clippy: fixes for "doc list item without indentation" lint * clippy: ignore incorrect "first doc comment paragraph is too long" warning see rust-lang/rust-clippy#13315 * clippy: allow long first paragraphs in select... fn doc comments * use workspace level setting to ignore error about the futures_sanitizer unexpected config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split into semantically separate commits for easier reviewing.
compiler warnings:
cfgcondition name: ... warnings introduced in Rust 1.80 (see https://blog.rust-lang.org/2024/05/06/check-cfg.html)clippy lints:
missing_const_for_thread_locallint was renamed tomissing_const_for_thread_local, but disabling it is no longer necessary since thread_local_initializer_can_be_made_const should respect MSRV rust-clippy#12404 has been fixedclippy doc lints:
too_long_first_doc_paragraphonly considers markdown source not the rendered output rust-clippy#13315)select... fn doc comments