Release 0.3.31 #2889
Merged
Release 0.3.31 #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
0.3-next
branch
4 times, most recently
from
066dd6a to
2f8a153
Compare
``` error: field `0` is never read --> futures-executor/tests/local_pool.rs:13:16 | 13 | struct Pending(Rc<()>); | ------- ^^^^^^ | | | field in this struct | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 13 | struct Pending(()); | ~~ ```
```
error: the item `Box` is imported redundantly
--> futures-core/src/future.rs:89:9
|
89 | use alloc::boxed::Box;
| ^^^^^^^^^^^^^^^^^
--> /rustc/381d69953bb7c3390cec0fee200f24529cb6320f/library/std/src/prelude/mod.rs:115:13
|
= note: the item `Box` is already defined here
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
error: the item `Box` is imported redundantly
--> futures-core/src/stream.rs:203:9
|
203 | use alloc::boxed::Box;
| ^^^^^^^^^^^^^^^^^
--> /rustc/381d69953bb7c3390cec0fee200f24529cb6320f/library/std/src/prelude/mod.rs:115:13
|
= note: the item `Box` is already defined here
```
```
warning: trait `AssertSync` is never used
--> futures-core/src/task/__internal/atomic_waker.rs:209:15
|
209 | trait AssertSync: Sync {}
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
warning: trait `AssertKinds` is never used
--> futures-channel/src/mpsc/mod.rs:130:7
|
130 | trait AssertKinds: Send + Sync + Clone {}
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
warning: trait `AssertSendSync` is never used
--> futures-executor/src/thread_pool.rs:48:7
|
48 | trait AssertSendSync: Send + Sync {}
| ^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
warning: trait `AssertSend` is never used
--> futures-channel/tests/mpsc.rs:13:7
|
13 | trait AssertSend: Send {}
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
```
```
error: redundant explicit link target
--> futures-executor/src/local_pool.rs:314:25
|
314 | /// Use a [`LocalPool`](LocalPool) if you need finer-grained control over
| ----------- ^^^^^^^^^ explicit target is redundant
| |
| because label contains path that resolves to same destination
|
= note: when a link's destination is not specified,
the label is used to resolve intra-doc links
= note: `-D rustdoc::redundant-explicit-links` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(rustdoc::redundant_explicit_links)]`
help: remove explicit link target
|
314 | /// Use a [`LocalPool`] if you need finer-grained control over
| ~~~~~~~~~~~~~
error: redundant explicit link target
--> futures-executor/src/local_pool.rs:37:33
|
37 | /// A handle to a [`LocalPool`](LocalPool) that implements
| ----------- ^^^^^^^^^ explicit target is redundant
| |
| because label contains path that resolves to same destination
|
= note: when a link's destination is not specified,
the label is used to resolve intra-doc links
help: remove explicit link target
|
37 | /// A handle to a [`LocalPool`] that implements
| ~~~~~~~~~~~~~
```
…t require inner trait bound (#2848)
They use pin_mut via futures-util.
* Fix unexpected `cfg` condition name: ... warnings introduced in Rust 1.80 See https://blog.rust-lang.org/2024/05/06/check-cfg.html * io_slice_advance feature is now stable * clippy: enable missing_const_for_thread_local lint, now checks for MSRV (see rust-lang/rust-clippy#12404) * clippy: fixes for "doc list item without indentation" lint * clippy: ignore incorrect "first doc comment paragraph is too long" warning see rust-lang/rust-clippy#13315 * clippy: allow long first paragraphs in select... fn doc comments * use workspace level setting to ignore error about the futures_sanitizer unexpected config
Signed-off-by: cuishuang <imcusg@gmail.com>
#2884) Fixes the following issues in `AsyncBufRead::read_line`: * When the future is dropped the previous string contents are not restored so the string is empty. * If invalid UTF-8 is encountered the previous string contents are not restored. * If an IO error occurs after `read_until_internal` already read a couple of bytes a debug assertion fails. * Performance: The whole string to which read contents are appended is check for UTF-8 validity instead of just the added bytes. Fixes the following issues in `AsyncBufRead::read_line`: * If an IO error occurs after `read_until_internal` already read a couple of bytes a debug assertion fails. (#2862) Fixes #2862
error: calling `set_len()` immediately after reserving a buffer creates uninitialized values
--> futures-util/src/io/buf_reader.rs:52:13
|
52 | let mut buffer = Vec::with_capacity(capacity);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
53 | buffer.set_len(capacity);
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[deny(clippy::uninit_vec)]` on by default
= help: initialize the buffer or wrap the content in `MaybeUninit`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninit_vec
taiki-e
force-pushed
the
0.3-next
branch
2 times, most recently
from
757f720 to
268e73e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
FuturesUnorderedwhen dropped future panics (Fix use after free of task in FuturesUnordered when dropped future panics #2886)task::waker_ref(Add 'static bound to waker_ref #2830)This is a breaking change but allowed because it is soundness bug fix.
AsyncBufRead::read_lineandAsyncBufReadExt::lines(Fix issues withAsyncBufRead::read_lineandAsyncBufReadExt::lines#2884)select!/select_biased!(Parse rhs ofselect!arms using match-arm rules #2832)This is technically a breaking change as it will now reject a very odd undocumented syntax that was previously accidentally accepted.
Waker::will_wakechange (#[inline(always)]onclone_arc_raw#2865)stream::Iter::{get_ref,get_mut,into_inner}(Add accessors for the inner of stream::Iter #2875)future::AlwaysReady(Add a helper for always ready futures #2825)io::{BufReader,BufWriter}(Make access inner of futures::io::{BufReader,BufWriter} not require inner trait bound #2848)Backports
select!arms using match-arm rules #2832#[inline(always)]onclone_arc_raw#2865AsyncBufRead::read_lineandAsyncBufReadExt::lines#2884BoxFutures /BoxStreams are often made #2887