[illumos] add pthread stack functions

[sunshowers]

The goal of this change is to make the following improvements possible:

• [illumos] enable guess_os_stack_limit stacker#88
• [illumos] stack exhaustion doesn't print "thread has overflowed its stack" messages rust#128568

Add some pthread stack functions:

• pthread_attr_get_np
• pthread_attr_getstackaddr
• pthread_attr_setstack
• pthread_attr_setstackaddr

I've verified that these functions exist and do the right thing.

Note that there doesn't appear to be a file like linux.txt for illumos specifically.

Another note: cd libc-test && cargo test currently fails on illumos with:

     Running test/main.rs (/home/rain/dev/libc/target/debug/deps/main-6329db179eb2b631)
RUNNING ALL TESTS
bad PTHREAD_MUTEX_DEFAULT value at byte 0: rust: 0 (0x0) != c 8 (0x8)
thread 'main' panicked at /home/rain/dev/libc/target/debug/build/libc-test-cefbf7853a50b4e4/out/main.rs:12:21:
some tests failed
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: test failed, to rerun pass `--test main`

But it also fails on main with the same error, so this isn't a regression.

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[rustbot]

Some changes occurred in solarish module

cc @jclulow, @pfmooney

[sunshowers]

Oh I guess I should target the 0.2 branch. Just a sec

[bors]

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

[pfmooney]

The tests are passing on illumos with this change included.

[tgross35]

Could you add an illumos.txt file in libc-test/semver and add these?

There are probably other functions that should be added once the file exists, but those can come separately.

[tgross35]

Also, can you target main? We can cherry pick from there.

[sunshowers]

Thanks @tgross35! Can do both of those things. (I wasn't sure about main vs 0.2, is there documentation somewhere about that? Sorry if I missed it.)

[tgross35]

(I wasn't sure about main vs 0.2, is there documentation somewhere about that? Sorry if I missed it.)

The README actually does suggest targeting 0.2, so you correctly did what is documented. I just intend to change that so we always update main and cherry-pick things to stable where needed, rather than maybe forgetting to apply some things to main and then losing fixes/additions when 1.0 is released.

The stable-nominated label can be applied with rustbot for any specific requests.

[rustbot]

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in OpenBSD module

cc @semarie

[sunshowers]

I just intend to change that so we always update main and cherry-pick things to stable where needed, rather than maybe forgetting to apply some things to main and then losing fixes/additions when 1.0 is released.

That makes sense! (Landing on main first and then cherry-picking is also the flow I personally recommend to folks :) )

Anyway, updated the PR. (Sorry about the rustbot ping, should have updated the base first.)

[tgross35]

Thanks for the changes! Feel free to submit a cherry-pick PR yourself once this merges (updated instructions coming here #3804), otherwise I will be doing a batch of them at some point.

[sunshowers]

Thanks for the changes! Feel free to submit a cherry-pick PR yourself once this merges (updated instructions coming here #3804), otherwise I will be doing a batch of them at some point.

This is #3807, thanks!