-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [
to the FOLLOW(ty) in macro future-proofing rules.
#1462
Add [
to the FOLLOW(ty) in macro future-proofing rules.
#1462
Conversation
Discussed with lang-team at meeting tonight; putting into Final Comment Period (FCP) now. (The reason for the quick FCP is because if we want to fix this, the only sensible time to do so is during the beta period, before the warning is promoted to a hard error.) |
Hear ye, hear ye. This RFC is now entering final comment period. |
Yes please. |
👍 |
Seems somewhat risky, were "type-level integers" to be added and made usable where constexprs are. Consider |
@cmr isn't that |
@durka I have no idea, but I wouldn't expect so. Lots of finnicky details around those proposals. |
Well maybe I don't understand what you mean. What is Certainly merging this RFC restricts future syntax choices slightly. I don't really have an opinion one way or the other, except I'm against breaking all of @retep998's crates :) |
In general a proposal could have the moral equivalent of expressions appearing in type-position. Whether they'd be treated as expr, for macros, or not I do not know. |
@cmr good point. My expectation though is that if we were ever to
embed expressions into types, we would need to have some kind of
"introduction syntax" anyhow. For example, I believe I've seen it
proposed that one might write `{expr}`, in which case the issue is
moot.
|
Huzzah! The language design subteam has decided to accept this RFC. |
Created tracking issue rust-lang/rust#31135 for this change specifically. |
Add
[
to the FOLLOW(ty) in macro future-proofing rules (RFC #550 )This is to address the regression rust-lang/rust#30923