Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [ to the follow set for ty #31135

Closed
nikomatsakis opened this issue Jan 22, 2016 · 2 comments
Closed

Add [ to the follow set for ty #31135

nikomatsakis opened this issue Jan 22, 2016 · 2 comments
Assignees
@pnkfelix
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

As decided in rust-lang/rfcs#1462.

cc @pnkfelix
cc @retep998
@nikomatsakis nikomatsakis added A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 22, 2016
@nikomatsakis nikomatsakis mentioned this issue Jan 22, 2016
Merged
@durka
Copy link
Contributor

durka commented Jan 23, 2016

So according to the RFC document, FOLLOW(path) = FOLLOW(ty). Does that mean we are adding [ to FOLLOW(path) as well? (My assumption is no.)

@durka durka mentioned this issue Jan 23, 2016
Merged
bors added a commit that referenced this issue Jan 23, 2016
@bors
Auto merge of #31152 - durka:ty-follow-bracket, r=pnkfelix
d5fcdcc 
cc #31135 rust-lang/rfcs#1462 #30923 @retep998
r? @pnkfelix
@nikomatsakis
Copy link
Contributor Author

Seems like yes. After all, a type can be just a path, so if we added a
[ suffix on paths, it would effectively add such a suffix to types
as well.

On Sat, Jan 23, 2016 at 09:20:33AM -0800, Alex Burka wrote:

So according to the RFC document, FOLLOW(path) = FOLLOW(ty). Does that mean we are adding [ to FOLLOW(path) as well?

Reply to this email directly or view it on GitHub:
#31135 (comment)

Manishearth added a commit to Manishearth/rust that referenced this issue Jan 26, 2016
@Manishearth
Rollup merge of rust-lang#31152 - durka:ty-follow-bracket, r=pnkfelix
b46bd2f 
cc rust-lang#31135 rust-lang/rfcs#1462 rust-lang#30923 @retep998
r? @pnkfelix
@bors bors closed this as completed in e1e0de8 Jan 26, 2016
@retep998 retep998 mentioned this issue Feb 4, 2016
Closed
pnkfelix pushed a commit to pnkfelix/rust that referenced this issue Feb 5, 2016
@durka @pnkfelix
add [ to FOLLOW(ty) and FOLLOW(path)
46049ee 
Following RFC 1462 (amending 550). Closes rust-lang#31135.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnkfelix pnkfelix

Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@durka @nikomatsakis @pnkfelix