Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo runnables no longer work #17402

Closed
Veykril opened this issue Jun 12, 2024 · 7 comments · Fixed by #17407 or #17549
Closed

cargo runnables no longer work #17402

Veykril opened this issue Jun 12, 2024 · 7 comments · Fixed by #17407 or #17549
Assignees
@davidbarsky
Labels
A-cargo cargo related issues Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug

Comments

@Veykril
Copy link
Member

Veykril commented Jun 12, 2024 

          It seems that after this PR, the tests have stopped running.

 *  Executing task: cargo cargo test --package sqruff-lib --lib -- rules::layout::LT13::tests::test_fail_leading_whitespace_comment --exact --show-output 

error: no such command: `cargo`

        View all installed commands with `cargo --list`
        Find a package to install `cargo` with `cargo search cargo-cargo`

Originally posted by @gvozdvmozgu in #16840 (comment)
@Veykril Veykril added Broken Window Bugs / technical debt to be addressed immediately A-cargo cargo related issues C-bug Category: bug labels Jun 12, 2024
@davidbarsky
Copy link
Contributor

ah jeez, yeah. I see why this is happening. lemme have some coffee; i'll put up a fix today.

@davidbarsky davidbarsky mentioned this issue Jun 12, 2024
Merged
@davidbarsky
Copy link
Contributor

should be fixed by #17407.

@eareimu
Copy link

eareimu commented Jun 13, 2024

have a look of this

@basdirks-purple
Copy link

have a look of this

That's hilarious. Nice workaround 😂

@bors bors closed this as completed in e059fea Jun 13, 2024
@CryZe
Copy link
Contributor

CryZe commented Jul 5, 2024 •
edited
Loading

This still reproduces as of v0.4.2024 (pre-release), i.e. the most recent pre-release. It's also broken in the stable release. v0.4.1997 (pre-release) is the last version that had working runnables it seems. After that apparently they broke entirely for a few versions and then the bug started happening.

@Veykril
Copy link
Member Author

Veykril commented Jul 5, 2024 •
edited
Loading

Huh? Indeed its broken again, but I don't recall us changing anything at all here since and it definitely did work again ...

@Veykril Veykril reopened this Jul 5, 2024
@Veykril
Copy link
Member Author

Veykril commented Jul 6, 2024

Turns out i misunderstood parts of the tasks API which caused weird problems (tasks working in some workspaces but not in others)

@Veykril Veykril mentioned this issue Jul 6, 2024
Merged
bors added a commit that referenced this issue Jul 6, 2024
@bors
Auto merge of #17549 - Veykril:runnables-fix, r=Veykril
1833fe3 
fix: Fix runnables being incorrectly constructed

I've misunderstood parts of the code here which caused runnables to arbitrarily break :) (I have yet to understand the conditions that made them break though, there is some odd caching involved I feel like ...)
Fixes #17402
@bors bors closed this as completed in 1adb52c Jul 6, 2024
lnicola pushed a commit to lnicola/rust that referenced this issue Jul 11, 2024
@bors
Auto merge of rust-lang#17549 - Veykril:runnables-fix, r=Veykril
e907f81 
fix: Fix runnables being incorrectly constructed

I've misunderstood parts of the code here which caused runnables to arbitrarily break :) (I have yet to understand the conditions that made them break though, there is some odd caching involved I feel like ...)
Fixes rust-lang/rust-analyzer#17402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidbarsky davidbarsky

Labels
A-cargo cargo related issues Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug
Projects
None yet
Milestone
No milestone
5 participants
@CryZe @davidbarsky @Veykril @basdirks-purple @eareimu