Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix runnables being incorrectly constructed #17549

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jul 6, 2024

I've misunderstood parts of the code here which caused runnables to arbitrarily break :) (I have yet to understand the conditions that made them break though, there is some odd caching involved I feel like ...)
Fixes #17402

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 6, 2024
@@ -323,14 +323,6 @@
{
"title": "general",
"properties": {
"rust-analyzer.cargoRunner": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removes this, the custom runner was broken for ages already so clearly no one is depending on it

@Veykril
Copy link
Member Author

Veykril commented Jul 6, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jul 6, 2024

📌 Commit 86a4844 has been approved by Veykril

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jul 6, 2024
fix: Fix runnables being incorrectly constructed

I've misunderstood parts of the code here which caused runnables to arbitrarily break :) (I have yet to understand the conditions that made them break though, there is some odd caching involved I feel like ...)
Fixes #17402
@bors
Copy link
Contributor

bors commented Jul 6, 2024

⌛ Testing commit 86a4844 with merge 1833fe3...

@Veykril
Copy link
Member Author

Veykril commented Jul 6, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jul 6, 2024

📌 Commit bb9678e has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 6, 2024

⌛ Testing commit bb9678e with merge 1adb52c...

@bors
Copy link
Contributor

bors commented Jul 6, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 1adb52c to master...

@bors bors merged commit 1adb52c into rust-lang:master Jul 6, 2024
11 checks passed
@Veykril Veykril deleted the runnables-fix branch September 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo runnables no longer work
3 participants