-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useless_asref
: do not lint .as_ref().map(Arc::clone)
#12535
Conversation
r? @Manishearth rustbot has assigned @Manishearth. Use |
r? @y21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, good idea to move it to utils
r=me with (or without if it doesn't make sense) doc nit fixed
bd1dd99
to
fed2f28
Compare
@bors r=y21 |
@samueltardieu: 🔑 Insufficient privileges: Not in reviewers |
I don't have the needed privileges, maybe you could have used delegate+ |
oops, my bad 😅 Thanks, looks good! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This applies to
Arc
,Rc
, and their weak variants. Using.clone()
would be less idiomatic.This follows the discussion in #12528 (comment).
changelog: [
useless_asref
]: do not lint.as_ref().map(Arc::clone)
and similar