Add regression test for #12612

[GuillaumeGomez]

Fixes #12612.
Fixes #12560.

Seems like this bug was fixed in #12535.

changelog: Add regression test for #12612 and #12560.

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Jarcho]

Both of those issues are only half fixed. map_clone still doesn't properly check the types involved.

[xFrednet]

Hey @GuillaumeGomez , this is a ping from triage, since there hasn't been any activity in some time. Are you still planning to continue this implementation?

If you have any questions, you're always welcome to ask them in this PR or on Zulip.

@rustbot author

[GuillaumeGomez]

I just confirmed again that the fix is done by adding a new test. I don't see what @Jarcho is referring to. Do you have an example where this bug can be reproduced by any chance?

[Jarcho]

The cause of both of those issues are the lint not verifying the types involved in the clone call. .map(|x: &X| Y::clone(...)) shouldn't be linted unless X and Y are the same type. #12535 happens to fix the issue when calling Arc::clone, but for an entirely different reason.

[Jarcho]

Looking into this again it does check the types correctly and there are already tests. This was actually fixed in #12282, not #12535.

[GuillaumeGomez]

Closing then!