Make restriction lint's use span_lint_and_then (i -> p)

[xFrednet]

This migrates a few restriction lints to use span_lint_and_then. This change is motivated by #7797.

I've also cleaned up some lint message. Mostly minor stuff. For example: suggestions with a longer message than "try" now use SuggestionStyle::ShowAlways

---

cc: #7797

brother PR of: #13136

changelog: none

[rustbot]

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[y21]

Is the plan to completely move away from these other span_lint_and_* functions? I feel like we should just remove that internal lint then 🤔. Seems odd that we require using functions that shouldn't be used or that we have to add #[expect]s everywhere.

I really liked span_lint_and_{sugg,help} more for when the messages are just plain string literals and that seems like it shouldn't make a difference there, but oh well

[xFrednet]

Is the plan to completely move away from these other span_lint_and_* functions?

That's a good question. The issue suggests the entire removal of these functions to have one unified way. I also think that rustc's diagnostic documentation is pretty good, which would make it easier for new contributors.

For restriction lints, I think it makes highly sense to remove them. Lints like implicit_return had previously created a suggestion for every implicit return. I slightly changed the message, and that's where lintcheck got the 60000+ changes from.

Now, I've kept the internal lint around, as I'm unsure, how motivated I am to migrate all of Clippy. These three PRs represent ~116 of our 700+ lints. Even if we create a migration lint it would take dedication. And rn I'm not sure if I'm committed enough for that. If we don't migrate all of Clippy, it would be better to keep the lint for consistency.

[y21]

Looks good, just two small "formatting" nits.

[xFrednet]

Very good catches! Thank you for taking the time =^.^=

The last commit, should have resolved everything.

[y21]

Looks all good to me now! Want to squash the last commit or keep it? You can r=me either way

[xFrednet]

And squashed :D

Thank you for the quick feedback =^.^=

---

Roses are red,
Violets are blue,
This has been approved,
by the one and only Timo

[bors]

📌 Commit 90c1963 has been approved by y21

It is now in the queue for this repository.

[bors]

⌛ Testing commit 90c1963 with merge 345c94c...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing 345c94c to master...