Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make restriction lint's use span_lint_and_then (q -> w) #13145

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

xFrednet
Copy link
Member

This migrates a few restriction lints to use span_lint_and_then. This change is motivated by #7797.

I've also cleaned up some lint message. Mostly minor stuff. For example: suggestions with a longer message than "try" now use SuggestionStyle::ShowAlways


cc: #7797

sister PR of: #13136

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 22, 2024
@xFrednet xFrednet changed the title Make restriction lint's use span_lint_and_then (q -> w) Make restriction lint's use span_lint_and_then (q -> w) Jul 23, 2024
@bors
Copy link
Contributor

bors commented Jul 26, 2024

☔ The latest upstream changes (presumably #13144) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet xFrednet force-pushed the 07797-restriction-and-then-why branch from a035915 to 514770b Compare July 26, 2024 08:03
@bors
Copy link
Contributor

bors commented Jul 27, 2024

☔ The latest upstream changes (presumably #13168) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet xFrednet force-pushed the 07797-restriction-and-then-why branch from 514770b to 4bf4c47 Compare July 27, 2024 11:45
@Jarcho
Copy link
Contributor

Jarcho commented Aug 6, 2024

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Aug 6, 2024

📌 Commit 4bf4c47 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 6, 2024

⌛ Testing commit 4bf4c47 with merge cfb3881...

@bors
Copy link
Contributor

bors commented Aug 6, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing cfb3881 to master...

@bors bors merged commit cfb3881 into rust-lang:master Aug 6, 2024
8 checks passed
@xFrednet xFrednet deleted the 07797-restriction-and-then-why branch August 6, 2024 07:13
@xFrednet xFrednet added the performance-project For issues and PRs related to the Clippy Performance Project label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance-project For issues and PRs related to the Clippy Performance Project S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants