Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove i686-unknown-dragonfly #287

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Conversation

tuxillo
Copy link
Contributor

@tuxillo tuxillo commented Dec 12, 2019

DragonFly BSD only supports x86_64 right now. i386 was removed a while ago.

DragonFly BSD only supports x86_64 right now. i386 was removed a while ago.
@jonas-schievink
Copy link
Contributor

Is the target still in the Rust codebase? It should be removed there first if so.

@tuxillo
Copy link
Contributor Author

tuxillo commented Dec 12, 2019

How should I verify that? In a rust repo checkout I can see:

# find . -iname "*686*dragon*"
./src/librustc_target/spec/i686_unknown_dragonfly.rs

@jonas-schievink
Copy link
Contributor

Yeah it's still in the code base then

@tuxillo
Copy link
Contributor Author

tuxillo commented Dec 12, 2019

How do plan its removal? Is there a list of procedure or guideline?

@jonas-schievink
Copy link
Contributor

Nah not really. We've removed Bitrig BSD support a while ago, you can take a look here (and the PR that closed the issue): rust-lang/rust#60743

@tuxillo
Copy link
Contributor Author

tuxillo commented Dec 15, 2019

The removal has been merged, let me know if I have to follow other steps.

@jonas-schievink
Copy link
Contributor

Should be fine, thanks!

@jonas-schievink jonas-schievink merged commit 952dd86 into rust-lang:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants