Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Bitrig support #60743

Closed
jonas-schievink opened this issue May 11, 2019 · 2 comments · Fixed by #60775
Closed

Remove Bitrig support #60743

jonas-schievink opened this issue May 11, 2019 · 2 comments · Fixed by #60775
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@jonas-schievink
Copy link
Contributor

Bitrig is a now defunct OpenBSD fork. It has been mostly successful and some of it's changes have been merged back into OpenBSD. It's development has halted ~2 years ago, and it never got another release after 1.0 in 2014.

Rust had some limited support for Bitrig (as a Tier 3 platform). I think we should remove the support to clean up the libstd code a bit.

(inspired by rust-lang/rust-forge#165, which just unlists it)
@jonas-schievink jonas-schievink added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 11, 2019
@hellow554 hellow554 mentioned this issue May 13, 2019
Merged
@kubo39 kubo39 mentioned this issue May 14, 2019
Closed
@ghost
Copy link

ghost commented May 14, 2019

@jonas-schievink the current maintainer of Rust port in OpenBSD is @semarie, he makes sure Rust and Cargo also work at aarch64-unknown-openbsd and i686-unknown-openbsd, so shouldn't those two be mentioned as Tier 3 at The Rust Forge?

@jonas-schievink
Copy link
Contributor Author

@mazocomp That makes sense to me! You can file a PR at https://github.com/rust-lang/rust-forge if you like.

bors added a commit that referenced this issue May 15, 2019
@bors
Auto merge of #60775 - hellow554:no_bitrig, r=joshtriplett
c84a7ab 
Remove bitrig support from rust

Resolves #60743

using `find` and `rg` I delete every occurence of "bitrig" in the sources, expect for the llvm submodule (is this correct?).

There's also this file https://github.com/rust-lang/rls/blob/5b8e99bb61958ca8abcb7c5eda70521726be1065/rls-analysis/test_data/rust-analysis/libstd-af9bacceee784405.json which contains a bitrig string in it. What to do with that?
@josephlr josephlr mentioned this issue Jul 7, 2019
Merged
@kubo39 kubo39 mentioned this issue Sep 24, 2019
Merged
Thomasdezeeuw pushed a commit to tokio-rs/mio that referenced this issue Oct 20, 2019
@kubo39 @Thomasdezeeuw
Remove bitrig support
c7bfba3 
support no longer exists for this target in Rust.
See rust-lang/rust#60743
@jonas-schievink jonas-schievink mentioned this issue Dec 12, 2019
Merged
@jakewilliami jakewilliami mentioned this issue Nov 15, 2022
Merged
3 tasks
@cakebaker cakebaker mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove bitrig support from rust hellow554/rust
1 participant
@jonas-schievink