Skip to content

Commit

Permalink
Reserve do as a keyword
Browse files Browse the repository at this point in the history
Resolves issue #12157. `do` is hereby reinstated as a keyword; no syntax is
associated with it though. Along the way, a unit test had to be adapted, since
it was using `do` as a method identifier.

Breaking changes:

- Any code using `do` as an identifier will no longer work.
  • Loading branch information
milibopp committed Feb 10, 2014
1 parent cf9164f commit a2fab45
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/libsyntax/parse/token.rs
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,7 @@ declare_special_idents_and_keywords! {
(53, Typeof, "typeof");
(54, Unsized, "unsized");
(55, Yield, "yield");
(56, Do, "do");
}
}

Expand Down
13 changes: 13 additions & 0 deletions src/test/compile-fail/keyword-do-as-identifier.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn main() {
let do = "bar"; //~ error: ident
}
6 changes: 3 additions & 3 deletions src/test/run-pass/temporary-lifetime-for-conditions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ impl Drop for Temporary {
}

impl Temporary {
fn do(&self) -> bool {true}
fn do_stuff(&self) -> bool {true}
}

fn borrow() -> ~Temporary { ~Temporary }
Expand All @@ -35,7 +35,7 @@ pub fn main() {
// This loop's condition
// should call `Temporary`'s
// `drop` 6 times.
while borrow().do() {
while borrow().do_stuff() {
i += 1;
if i > 5 {
break;
Expand All @@ -44,7 +44,7 @@ pub fn main() {

// This if condition should
// call it 1 time
if borrow().do() {
if borrow().do_stuff() {
unsafe { assert_eq!(DROPPED, 7) }
}
}

5 comments on commit a2fab45

@bors
Copy link
Contributor

@bors bors commented on a2fab45 Feb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from brson
at milibopp@a2fab45

@bors
Copy link
Contributor

@bors bors commented on a2fab45 Feb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging aepsil0n/rust/feature/reserve_do_keyword = a2fab45 into auto

@bors
Copy link
Contributor

@bors bors commented on a2fab45 Feb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aepsil0n/rust/feature/reserve_do_keyword = a2fab45 merged ok, testing candidate = 86e6a5c

@bors
Copy link
Contributor

@bors bors commented on a2fab45 Feb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on a2fab45 Feb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 86e6a5c

Please sign in to comment.