Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve 'do' keyword #12157

Closed
brson opened this issue Feb 10, 2014 · 6 comments
Closed

Reserve 'do' keyword #12157

brson opened this issue Feb 10, 2014 · 6 comments
Labels
A-parser Area: The parsing of Rust source code to an AST E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 10, 2014

'do' is not even reserved now. This has too many potential uses for us to lose, in my opinion, so we should reserve it.
@brson
Copy link
Contributor Author

brson commented Feb 10, 2014

Nominating.

@pnkfelix
Copy link
Member

+1

@milibopp
Copy link
Contributor

I would like to give it try. I'm new to Rust and this seems easy and low-priority enough to get started digging into the code.

@brson
Copy link
Contributor Author

brson commented Feb 10, 2014

@aepsil0n ok!

milibopp added a commit to milibopp/rust that referenced this issue Feb 10, 2014
@milibopp
Reserve do as a keyword
a2fab45 
Resolves issue rust-lang#12157. `do` is hereby reinstated as a keyword; no syntax is
associated with it though. Along the way, a unit test had to be adapted, since
it was using `do` as a method identifier.

Breaking changes:

- Any code using `do` as an identifier will no longer work.
@milibopp milibopp mentioned this issue Feb 10, 2014
Merged
bors added a commit that referenced this issue Feb 11, 2014
@bors
auto merge of #12170 : aepsil0n/rust/feature/reserve_do_keyword, r=brson
86e6a5c 
This resolves issue #12157. Does that do it already or is there something else that needs taking care of?  

As a side note, there seems to be some documentation, in which the old existence of the do keyword is explained. The list of keywords is not up-to-date either. But these are certainly separate issues.
@nikomatsakis
Copy link
Contributor

+1

@flaper87
Copy link
Contributor

Closing, This was fixed by a2fab45

@darnuria darnuria mentioned this issue Feb 18, 2014
Closed
bors added a commit that referenced this issue Feb 19, 2014
@bors
auto merge of #12367 : darnuria/rust/tutorial_removing_do_syntax, r=cmr
d2f265d 
The 'do' keyword was deprecated in 0.10 #11868 , and is keep as
reserved keyword  #12157 .

So the tutorial part about it doesn't make sense.
The spawning explanation was move into '15.2 Closure compatibility'.
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12157 - lnicola:lower-char-byte-literals, r=V…
e789d73 
…eykril

feat: Lower values of char and byte literals

Closes rust-lang#12137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser Area: The parsing of Rust source code to an AST E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@flaper87 @brson @nikomatsakis @pnkfelix @milibopp