Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for rustdoc search indices #13444

Closed
lifthrasiir opened this issue Apr 10, 2014 · 2 comments
Closed

Tests for rustdoc search indices #13444

lifthrasiir opened this issue Apr 10, 2014 · 2 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@lifthrasiir
Copy link
Contributor

The generation of search index has some delicate corner cases (e.g. #11391) that will benefit from tests. We at least need equivalence tests which compare a generated search index from given file with the expected one.
@lifthrasiir lifthrasiir mentioned this issue Apr 10, 2014
Merged
@SiegeLord SiegeLord mentioned this issue Aug 26, 2014
Merged
@lifthrasiir lifthrasiir mentioned this issue Dec 11, 2014
Closed
@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 23, 2015
@steveklabnik
Copy link
Member

Triage: no change.

@mitaa mitaa mentioned this issue Feb 8, 2016
Closed
@steveklabnik steveklabnik added T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. and removed T-tools labels May 18, 2017
@Mark-Simulacrum Mark-Simulacrum added the E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. label Jun 26, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 21, 2017
@QuietMisdreavus QuietMisdreavus mentioned this issue Aug 7, 2017
Open
@QuietMisdreavus
Copy link
Member

Thanks to #47250, this exists now! Right now it's bound to the standard library's search index, but so far that's been good enough to test the problem cases we've had.

compiler-errors pushed a commit to compiler-errors/rust that referenced this issue Oct 26, 2022
@bors
Auto merge of rust-lang#13444 - Veykril:rethrow-err, r=Veykril
32614e2 
fix: Don't catch the server activation error

We are are rethrowing and showing errors higher up in the call stack already. This just ate the error hiding the stacktrace unnecessarily.
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 18, 2024
@bors
Auto merge of rust-lang#13444 - kpreid:fix-8524-private-rep, r=blyxyas
55f6029 
`module_name_repetitions`: don't warn if the item is in a private module.

Fixes <rust-lang/rust-clippy#8524>.

There is still a warning (as there should be) if the item is reexported by name, but not by glob; that would require further work to examine the names in the glob, and I haven't looked into that.

Credit to `@Centri3` for suggesting approximately this simple fix in <rust-lang/rust-clippy#8524 (comment)>. However, per later comment <rust-lang/rust-clippy#8524 (comment)>, I am not making it configuration-dependent, but *always* checking public items in public modules only.

changelog: [`module_name_repetitions`]: don't warn if the item is in a private module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check the search-index generated by rustdoc tests mitaa/rust
4 participants
@steveklabnik @lifthrasiir @Mark-Simulacrum @QuietMisdreavus