Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always insert methods into the search index, even if we're currently in a private module #16767

Merged
merged 2 commits into from
Aug 29, 2014

Conversation

SiegeLord
Copy link
Contributor

Previously, this caused methods of re-exported types to not be inserted into
the search index. This fix may introduce some false positives, but in my
testing they appear as orphaned methods and end up not being inserted into the
final search index at a later stage.

Fixes issue #11943

…in a private module.

Previously, this caused methods of re-exported types to not be inserted into
the search index. This fix may introduce some false positives, but in my
testing they appear as orphaned methods and end up not being inserted into the
final search index at a later stage.

Fixes issue rust-lang#11943
@emberian
Copy link
Member

@SiegeLord could you add a test for this, perhaps just by grepping the index file?

@SiegeLord
Copy link
Contributor Author

Rustdoc testing seems like a big project in itself (#13444)... let me glance at how tests are done these days, but I imagine it'll take me awhile to do this.

@emberian
Copy link
Member

I usually just throw a quick script in run-make.

On Tue, Aug 26, 2014 at 5:37 PM, SiegeLord notifications@github.com wrote:

Rustdoc testing seems like a big project in itself (#13444
#13444)... let me glance at how
tests are done these days, but I imagine it'll take me awhile to do this.


Reply to this email directly or view it on GitHub
#16767 (comment).

http://octayn.net/

@SiegeLord
Copy link
Contributor Author

Ok, added a simple test.

@huonw huonw closed this Aug 28, 2014
@huonw
Copy link
Member

huonw commented Aug 28, 2014

(Cycling to hopefully unstick bors.)

@huonw huonw reopened this Aug 28, 2014
bors added a commit that referenced this pull request Aug 29, 2014
Previously, this caused methods of re-exported types to not be inserted into
the search index. This fix may introduce some false positives, but in my
testing they appear as orphaned methods and end up not being inserted into the
final search index at a later stage.

Fixes issue #11943
@bors bors closed this Aug 29, 2014
@bors bors merged commit 0db6f4c into rust-lang:master Aug 29, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Jun 23, 2024
…=Veykril

internal: Expose snippet capability to diagnostic quickfixes

Fixes rust-lang#16767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants