Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: External implementors for inlined traits are not shown #33025

Closed
mitaa opened this issue Apr 16, 2016 · 0 comments · Fixed by #33133
Closed

rustdoc: External implementors for inlined traits are not shown #33025

mitaa opened this issue Apr 16, 2016 · 0 comments · Fixed by #33133

Comments

@mitaa
Copy link
Contributor

mitaa commented Apr 16, 2016

When re-exporting a external trait, the implementors section of that (inlined) trait does not show external implementors of it (unless they too have been inlined).
Re-exported external types on the other hand do show external trait implementations.

// foo.rs
extern crate bar;

pub use bar::Bar;
// bar.rs
pub trait Bar {}
pub struct Baz;

// this impl does not show up in `foo::Bar`s implementors section
impl Bar for Baz {}
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 25, 2016
…ichton

rustdoc: inline all the impls

This used to be done to avoid inlining impls referencing private items, but is now unnecessary since we actually check that impls do not reference non-doc-reachable items.

fixes rust-lang#32881
fixes rust-lang#33025
fixes rust-lang#33113

r? @alexcrichton
Munksgaard added a commit to Munksgaard/rust that referenced this issue Oct 11, 2018
There was an issue (rust-lang#33025) which caused these tests to not work. The issue has
since been fixed in rust-lang#33133, and so we can now include them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant