Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: make clean doesn't clean enough #33986

Closed
alexcrichton opened this issue May 31, 2016 · 0 comments
Closed

rustbuild: make clean doesn't clean enough #33986

alexcrichton opened this issue May 31, 2016 · 0 comments
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@alexcrichton
Copy link
Member

Errors like http://buildbot.rust-lang.org/builders/auto-linux-64-cross-netbsd/builds/462 are happening on the bots, e.g.:

   Compiling bootstrap v0.0.0 (file:///buildslave/rust-buildbot/slave/auto-linux-64-cross-netbsd/build/src/bootstrap)
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
thread 'rustc' panicked at 'called `Result::unwrap()` on an `Err` value: Utf8Error { valid_up_to: 0 }', ../src/libcore/result.rs:746
note: Run with `RUST_BACKTRACE=1` for a backtrace.

error: Could not compile `bootstrap`.

To learn more, run the command again with --verbose.

This is #33778 under the covers, but rustbuild's make clean command should blow away the build system directory ahead of time to be more resilient to bugs like this.
@alexcrichton alexcrichton added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) labels May 31, 2016
@alexcrichton alexcrichton mentioned this issue May 31, 2016
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 31, 2016
@alexcrichton
rustbuild: Clean more on make clean
ac19420 
Be sure to not use the old build cache for the bootstrap build system nor the
old caches of the compiler/cargo extractions (in case something went wrong).

Closes rust-lang#33986
@alexcrichton alexcrichton mentioned this issue May 31, 2016
Merged
@retep998 retep998 mentioned this issue May 31, 2016
Merged
bors added a commit that referenced this issue Jun 4, 2016
@bors
Auto merge of #33991 - alexcrichton:rustbuild-more-clean, r=aturon
4fb1458 
rustbuild: Clean more on `make clean`

Be sure to not use the old build cache for the bootstrap build system nor the
old caches of the compiler/cargo extractions (in case something went wrong).

Closes #33986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexcrichton