Attempt to diagnose #33844 #33979
Attempt to diagnose #33844 #33979
Conversation
|
Picture evidence that this PR prints out the linker arguments in that failure case. |
| @@ -40,7 +40,9 @@ pub fn gnu_target(target: &str) -> String { | |||
| } | |||
|
|
|||
| pub fn cc2ar(cc: &Path, target: &str) -> PathBuf { | |||
| if target.contains("musl") || target.contains("msvc") { | |||
| if target.contains("msvc") { | |||
| PathBuf::from("lib") | |||
There was a problem hiding this comment.
Can this change be saved for later? Papering over this unfortunately probably won't fix much, the syntax for calling lib is very different than ar, so this will never work if it's actually used. This should basically just return an option and then it's handled elsewhere when it's not available
There was a problem hiding this comment.
It fixes the sanity check. In all cases where cc2ar is called or the .ar() of the Build is called, the result is never used on msvc, except for the sanity check. But I'll move it to a separate PR and do the Option thing.
Needed to diagnose rust-lang#33844 Signed-off-by: Peter Atashian <retep998@gmail.com>
retep998
force-pushed
the
why-the-long-face
branch
2 times, most recently
from
a1edc05
to
d34ad3c
Compare
|
Updated to always print out the linker command if rustc fails to invoke the linker. |
|
⌛ Testing commit d34ad3c with merge 54c0f00... |
|
💔 Test failed - auto-linux-64-cross-armhf |
|
@bors: retry On Tue, May 31, 2016 at 3:47 PM, Peter Atashian notifications@github.com
|
Attempt to diagnose #33844 #33844 is a spurious failure that causes builds to fail due to the linker command sometimes failing with error 206, which means that the command is too long. This PR makes rustc print out the linker arguments in that case so the reason for it being so long can be diagnosed and hopefully fixed. r? @alexcrichton
#33844 is a spurious failure that causes builds to fail due to the linker command sometimes failing with error 206, which means that the command is too long. This PR makes rustc print out the linker arguments in that case so the reason for it being so long can be diagnosed and hopefully fixed.
r? @alexcrichton