Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate trait items from trait #37712

Closed
nikomatsakis opened this issue Nov 11, 2016 · 3 comments
Closed

Separate trait items from trait #37712

nikomatsakis opened this issue Nov 11, 2016 · 3 comments
Assignees
@eddyb
Labels
A-incr-comp Area: Incremental compilation C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

PR #37660 separates impl items from impls in the HIR for improved interaction with incremental compilation. It probably makes sense to separate trait items from traits too -- not so much for improved incremental compilation precision, as because it makes the layout more analogous.
@nikomatsakis nikomatsakis added A-incr-comp Area: Incremental compilation E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Nov 11, 2016
@nikomatsakis
Copy link
Contributor Author

nikomatsakis commented Nov 11, 2016 •
edited
Loading

Marking this as E-mentor. I'll give a short write-up here; happy to provide a more detailed one too upon request!

The work that needs to be done is basically to model trait items on impl items -- we would get a hir::TraitItemRef like hir::ImplItemRef, a separate map in the Krate to store them, and modify the lowering routines analogously. Finally, there are a few places (marked with FIXMEs attached to this issue number) where we could convert to using a ItemLikeVisitor if trait items were considered "item like".

@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Nov 11, 2016
@eddyb
Copy link
Member

eddyb commented Nov 30, 2016

Apologies to anyone who wanted to pick this up, but I was blocked on it so I did it, PR coming soon.

@eddyb eddyb removed the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Nov 30, 2016
@eddyb eddyb self-assigned this Nov 30, 2016
This was referenced Dec 14, 2016
Closed
Merged
bors added a commit that referenced this issue Dec 28, 2016
@bors
Auto merge of #38449 - eddyb:lazy-10, r=nikomatsakis
4ecc85b 
[10/n] Split constants and functions' arguments into disjoint bodies.

_This is part of a series ([prev](#38053) | [next]()) of patches designed to rework rustc into an out-of-order on-demand pipeline model for both better feature support (e.g. [MIR-based](https://github.com/solson/miri) early constant evaluation) and incremental execution of compiler passes (e.g. type-checking), with beneficial consequences to IDE support as well.
If any motivation is unclear, please ask for additional PR description clarifications or code comments._

<hr>

Finishes the signature-body split started in #37918, namely:
* `trait` items are separated just like `impl` items were, for uniformity, closing #37712
* `static`s, `const`s (including associated ones), `enum` discriminants and array lengths get bodies
  * even the count in "repeat expressions", i.e. `n` in `[x; n]`, which fixes #24414
* arguments' patterns are moved to the bodies, with the types staying in `FnDecl`
  * `&self` now desugars to `self: &Self` instead of `self: &_` (similarly for other `self` forms)
  * `astconv`'s and metadata's (for rustdoc) informative uses are explicitly ignored for the purposes of the dep graph. this could be fixed in the future by hashing the exact information being extracted about the arguments as opposed to generating a dependency on *the whole body*
@eddyb
Copy link
Member

eddyb commented Jan 5, 2017

Somehow the merge of #38449 didn't close this.

@eddyb eddyb closed this as completed Jan 5, 2017
@oli-obk oli-obk mentioned this issue Sep 6, 2017
Open
nivkner added a commit to nivkner/rust that referenced this issue Feb 16, 2018
@nivkner
remove FIXME(rust-lang#37712) and implement ItemLikeVisitor instead o…
9e64088 
…f Visitor
nivkner added a commit to nivkner/rust that referenced this issue Mar 17, 2018
@nivkner
remove FIXME(rust-lang#37712) and implement ItemLikeVisitor instead o…
622c445 
…f Visitor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

Labels
A-incr-comp Area: Incremental compilation C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddyb @nikomatsakis